Skip to content

Fix BMC ITSM Incoming Mapper issues#43749

Open
content-bot wants to merge 2 commits intomasterfrom
contrib/mcvic1rj_bugfix/BMC-ITSM-null-issue
Open

Fix BMC ITSM Incoming Mapper issues#43749
content-bot wants to merge 2 commits intomasterfrom
contrib/mcvic1rj_bugfix/BMC-ITSM-null-issue

Conversation

@content-bot
Copy link
Copy Markdown
Contributor

@content-bot content-bot commented Mar 30, 2026

Original External PR

external pull request

Contributor

@mcvic1rj

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

No Jira/support tickets

Description

When the integration fetches, if one of the keys has a null value, it prevents the layout from displaying the information it does have.

Must have

  • Tests
  • Documentation

fixes: https://jira-dc.paloaltonetworks.com/browse/CIAC-16228

@mcvic1rj @kamalq97
Fix BMC ITSM Incoming Mapper issues (#43448)
ee30bdd 
* bug fix - XSOAR 6 does not map grid fields if there is a null value

* Updated field mappings, and internal code maps

---------

Co-authored-by: Kamal Qarain <45042524+kamalq97@users.noreply.github.com>
@content-bot content-bot added Contribution Thank you! Contributions are always welcome! docs-approved Contribution Form Filled Whether contribution form filled or not. Community pending-contributor The PR is pending the response of its creator Xsoar Support Level Indicates that the contribution is for XSOAR supported pack Internal PR Security Review Contribution On Hold Indicates that the contribution is on hold and no work is done on this PR at the moment Security Approved If a contribution has been approved for merge by the security team, then this will allow a merge ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines labels Mar 30, 2026
@content-bot content-bot requested a review from kamalq97 March 30, 2026 15:04
@content-bot
Copy link
Copy Markdown
Contributor Author

content-bot commented Mar 30, 2026

🤖 AI-Powered Code Review Available

Hi @kamalq97, you can leverage AI-powered code review to assist with this PR!

Available Commands:

  • @marketplace-ai-reviewer start review - Initiate a full AI code review
  • @marketplace-ai-reviewer re-review - Incremental review for new commits

@content-bot
Copy link
Copy Markdown
Contributor Author

content-bot commented Mar 30, 2026

🤖 AI-Powered Code Review Available

You can leverage AI-powered code review to assist with this PR!

Available Commands:

  • @marketplace-ai-reviewer start review - Initiate a full AI code review
  • @marketplace-ai-reviewer re-review - Incremental review for new commits

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 30, 2026 •
edited
Loading

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/BmcITSM/Integrations/BmcITSM
   BmcITSM.py101017982%403–406, 408–409, 416, 421–424, 479–483, 1664, 1801–1803, 1937–1938, 1940–1942, 1948, 2188, 2342, 3283, 3298, 3314, 3338–3345, 3348, 3390–3393, 3397, 3406, 3415–3416, 3418, 3500–3501, 3737–3739, 3749, 3751–3752, 3755, 3903, 3919–3921, 3925, 4002, 4016–4026, 4037, 4051–4053, 4055–4056, 4058–4060, 4068–4069, 4071–4073, 4075, 4090–4092, 4094–4095, 4098, 4100–4101, 4103–4104, 4106–4108, 4110–4111, 4113–4115, 4118, 4131, 4143, 4155–4158, 4169–4174, 4176, 4178, 4191, 4200, 4211–4212, 4219–4226, 4228–4237, 4239–4244, 4246–4248, 4250, 4281–4284, 4297–4308, 4310, 4312–4317, 4319
TOTAL101017982% 

Tests Skipped Failures Errors Time
51 0 💤 0 ❌ 0 🔥 2.818s ⏱️

@kamalq97 kamalq97 added skip-ai-review and removed Contribution On Hold Indicates that the contribution is on hold and no work is done on this PR at the moment labels Mar 30, 2026
@kamalq97 kamalq97 enabled auto-merge (squash) March 30, 2026 15:21
@content-bot
Copy link
Copy Markdown
Contributor Author

content-bot commented Mar 30, 2026

Validate summary
The following errors were thrown as a part of this pr: RN107.
The following errors cannot be ignored: RN107.
If the AG100 validation in the pre-commit GitHub Action fails, the pull request cannot be force-merged.
The following errors don't run as part of the nightly flow and therefore can be force merged: RN107.

Verdict: PR can be force merged from validate perspective? ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kamalq97 kamalq97 kamalq97 approved these changes

Assignees

@kamalq97 kamalq97

@Benimanela Benimanela

Labels

Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! docs-approved Internal PR pending-contributor The PR is pending the response of its creator ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines Security Approved If a contribution has been approved for merge by the security team, then this will allow a merge Security Review skip-ai-review Xsoar Support Level Indicates that the contribution is for XSOAR supported pack

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@content-bot @kamalq97 @Benimanela @mcvic1rj