Repository navigation
Conversation
gabotechs
marked this pull request as draft
November 12, 2026 13:05
gabotechs
commented
Nov 12, 2026
Comment on lines
+107
to
+108
| #[derive(Default)] | ||
| pub(crate) struct RoundtripProtoConverter { |
Collaborator
Author
There was a problem hiding this comment.
A bit annoying that we need this committed here...
gabotechs
force-pushed
the
gabotechs/roundtrip-single-node
branch
from
November 12, 2026 13:29
e03117a to
b7801e0
Compare
roundtrip_pb now serializes only the node it is given: its children are swapped for EmptyExec placeholders during the round-trip and put back afterwards. Severing in-memory dynamic filter relationships round-trips only the nodes holding dynamic filters (and only the anchors of network boundaries) through a shared RoundtripProtoConverter, so nodes that shared a dynamic filter before still share it after.
gabotechs
force-pushed
the
gabotechs/roundtrip-single-node
branch
from
November 19, 2026 10:58
b7801e0 to
576a2f2
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
roundtrip_pbnow round-trips only the node it's given, instead of the whole subtree below it. Its children are swapped forEmptyExecplaceholders during the round-trip and put back afterwards, which is whatisolate_sort_dynamic_filters_for_displaywas already doing by hand.Round-tripping whole subtrees meant that any round-trip done during planning also serialized the network boundaries below it, worker URLs included. A follow-up PR makes those URLs unknown at that point, so this needs to stop.
Severing in-memory dynamic filter relationships can't just round-trip the whole plan anymore, but nodes in the same plan still have to keep sharing their dynamic filters afterwards.
DeduplicatingProtoConverteronly dedups within a single call, so this adds aRoundtripProtoConverterwhose dedup cache lives as long as the instance. The sever now walks the plan and round-trips only the nodes that hold dynamic filters, all through one converter. For network boundaries, only theirdynamic_filter_anchorsare round-tripped.No behaviour change is intended. The existing dynamic filtering integration tests cover the shared converter: giving each node its own converter makes 5 of them fail.