Repository navigation
Conversation
gabotechs
marked this pull request as draft
November 12, 2026 13:05
gabotechs
force-pushed
the
gabotechs/task-reports-on-drop
branch
from
November 12, 2026 13:29
683ce71 to
b5c3f6d
Compare
The worker->coordinator task only filled in default metrics and completed dynamic filters after the stream ended cleanly. When the stream returned an error (or recording a dynamic filter update failed), the task exited through `?` and wait_for_metrics() hung forever for that task. Move the stores into a TaskReports guard that inserts the defaults on drop, so the waits complete however the task ends.
gabotechs
force-pushed
the
gabotechs/task-reports-on-drop
branch
from
November 19, 2026 10:58
b5c3f6d to
7369648
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #879.
The worker->coordinator task only filled in default metrics and completed dynamic filters for a task after its stream ended cleanly. If the stream returned an error, or recording a dynamic filter update failed, the task exited through
?and skipped them.DistributedExec::wait_for_metrics()then hung forever waiting for that task.Changes
The metrics and completed dynamic filter stores now live in a
TaskReportsguard that inserts the defaults on drop. The waits complete however the task ends: cleanly, with an error, or dropped before it is ever polled.Testing
metrics_collected_after_worker_stream_error(intests/metrics_collection.rs) uses a route handler that fails task 0's worker->coordinator stream after the first output batch. That error arrives before the final reports. Without the fix, the test times out inwait_for_metrics().🤖 Generated with Claude Code