feat(symbol): Allow to set custom symbol#74
Merged
Conversation
david-bretaud-dev
force-pushed
the
david-bretaud-dev/feat-add-custom-symbols
branch
from
035613d to
ae4f174
Compare
david-bretaud-dev
force-pushed
the
david-bretaud-dev/feat-add-custom-symbols
branch
2 times, most recently
from
0176e38 to
0ac902f
Compare
arnaudfnr
reviewed
Apr 17, 2026
| pictureId = imageId; | ||
| } | ||
|
|
||
| if (svg) { |
Collaborator
There was a problem hiding this comment.
What happens if both imageUrl and svg are set ?
Collaborator
Author
There was a problem hiding this comment.
I would have said "no worries, ts does not allow that" but not all consumers projects will be in typescript 😮💨 I'll add constraints
Collaborator
Author
There was a problem hiding this comment.
Updated with
- early return when it's configured
- additional JSDoc
- warning when nothing is provided
david-bretaud-dev
force-pushed
the
david-bretaud-dev/feat-add-custom-symbols
branch
from
0ac902f to
99355f7
Compare
arnaudfnr
approved these changes
Apr 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#64