Feat: Support 'layerType' key config.json#76
Merged
Conversation
Collaborator
|
why not keeping the key as "type" so we stay aligned with maplibre layer properties ? |
Collaborator
Author
I can do that but 'type' was already used, so I did the smallest change. |
Collaborator
|
Ah yeah right, so that's fine, i think we will need to make something cleaner for layer configs because it's weird that we mix maplibre config and coordo config IMO but we can do this after the season |
Cabanon
approved these changes
Apr 17, 2026
arnaudfnr
force-pushed
the
arnaudfnr/add_layer_type
branch
from
40481e5 to
fe3ce33
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
This PR is related to #64 and #74.
We want to create layers of type "symbol" in order to show icons instead of circles as data points in the map.
However, currently the layer type is inferred from the geometry type. But in the case of 'symbols' the layer type can be anything and therfore it should be set directly in the config.json.
Another strategy would be to infer the layer type into 'symbol' in case other data keys are present in the config.json, like "layout": { "icon-image": "someUrl" } for instance, but it would make the code a bit more complex.