Skip to content
This repository was archived by the owner on Jan 19, 2022. It is now read-only.

Fix outdated mini_file_server.dart#61

Open
stevenanthonyrevo wants to merge 5 commits into
dart-archive:masterfrom
stevenanthonyrevo:patch-1
Open

Fix outdated mini_file_server.dart#61
stevenanthonyrevo wants to merge 5 commits into
dart-archive:masterfrom
stevenanthonyrevo:patch-1

Conversation

@stevenanthonyrevo

Copy link
Copy Markdown

Issue - dart-lang/site-www#2646 - Propose to fix mini server example continuous loop on the connection.

Issue - dart-lang/site-www#2646 - Propose to fix mini server example continuous loop on the connection.
@googlebot

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot

Copy link
Copy Markdown

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@stevenanthonyrevo

Copy link
Copy Markdown
Author

@googlebot I signed it!

@stevenanthonyrevo stevenanthonyrevo left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Propose to fix mini server example continuous loop on the connection.

@stevenanthonyrevo stevenanthonyrevo left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To fix blocking variables with a standard "string" message

Comment thread httpserver/bin/mini_file_server.dart
To resolve the dart type issues within the print statement feedback on the server response. 
Expected response `Listening on 127.0.0.1:4044` on call instead of `Listening on localhost:4044`

@stevenanthonyrevo stevenanthonyrevo left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kwalrath If you would be kind to see my revisions regarding the type difference.

@kwalrath kwalrath left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think what we need to do is just copy https://github.com/dart-lang/site-www/blob/master/examples/httpserver/bin/mini_file_server.dart to this repo. That'll get rid of some problems like the unnecessary import of dart:async.

(It's kind of terrible that we have the code in 2+ places. I believe that @redbrogdon will make sure this duplication gets fixed, one way or another.)

Comment thread httpserver/bin/mini_file_server.dart Outdated
I've edited single quotes for example file instead of double based on conversation. 
These can be merged.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Development

Successfully merging this pull request may close these issues.

3 participants