Fix known issues: Tutorial 'Write HTTP clients & servers' doesn't workk as expected

[Classy-Bear]

The issue was opened here. The server finally ends (closes) the response(s). The file is served as it says in the tutorial.

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[Classy-Bear]

@googlebot I signed it!

[googlebot]

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

[kwalrath]

I can't see the difference... Can you tell me what changed?

[Classy-Bear]

Sure! The response wasn't being closed, since it wasn't being reached because of the if/else statement.

We had this:

if (await targetFile.exists()) {
...
} else { 
      ...
      await req.response.close();
}

If the file exists the response will not be closed because the else statement will not be executed. So I take out the line where the response is being closed and put it outside the else statement:

if (await targetFile.exists()) {
...
} else { 
      ...
}
await req.response.close();

So now matter what happen the response will be closed.

If the response is not closed, the response will hang and no file will be served.

[kwalrath]

Thanks! I missed that it had moved outside the braces.

[stevenanthonyrevo]

@kwalrath, I am sorry but I think there is a misunderstanding.

The original pull request was here, more specifically here, if there were questions or concerns, I should have received a review?

No worries, looks like the problem is solved already.

But you are missing a few changes, I suggested in my PR.