Ignore statements containing only semicolons or whitespace#501
Merged
Conversation
matriv
reviewed
Jun 10, 2026
| cmd._exec = Mock() | ||
| cmd.process(";") | ||
| cmd.process(";;\n;") | ||
| cmd.process(" \n\t") |
Contributor
There was a problem hiding this comment.
should we also add a test with only comments and maybe spanning multiple lines?
SAY-5
force-pushed
the
fix-empty-statement-crash
branch
from
78bad1c to
0bb8b68
Compare
Contributor
Author
|
Added test_statement_with_only_comments in 0bb8b68 covering a single-line comment, two comment lines, and a multi-line /* */ block, all asserting nothing gets executed. Confirmed it fails without the skip in _process_sql. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #499.
Submitting a statement that contains only
;(or only whitespace/comments) crashed crash withIndexError: list index out of rangefromstmt_type(), sincere.findall(r'[\w]+', ...)returns an empty list._process_sqlnow skips statements that have no word characters after stripping comments, so an empty line is written instead of crashing.Added a regression test in
MultipleStatementsTest.