fix: handle statements with only semicolons/whitespace#500
Closed
SAY-5 wants to merge 2 commits into
Closed
Conversation
Input consisting solely of ';' produced a statement whose first token is Punctuation. stmt_type then called re.findall(r'[\w]+', ';')[0], raising IndexError. Skip empty statements in _process_sql and harden stmt_type to return '' when the statement contains no word tokens. Fixes crate#499
Contributor
Author
|
Closing this one, #501 carries the same fix with a test and a CHANGES entry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #499.
Entering
;at the crash prompt crashed withIndexError: list index out of range. The first token of the parsed statement is a Punctuation, andre.findall(r'[\w]+', ';')[0]indexes an empty list. Skip empty statements in_process_sqland hardenstmt_typeto return''when the statement has no word tokens. Regression test added inCommandUtilsTest.test_stmt_type_punctuation_only_does_not_crash.