Repository navigation
fix: keep docs images on tags and stop unappliable digest pins - #265
Merged
Merged
Conversation
Turn off digest pinning for every image in cplieger/docs. Its examples are copied verbatim into the guide pages, and the docs/*.md manager can move a tag but not write a digest, so a pinned bump made the example and its copy differ and failed the snippet check on main. Turn off digest pinning for the docs/*.md manager everywhere. Its pin updates can never be applied, so the pin-dependencies branch errored on every run in cplieger/docs, docker-fclones-scheduler, docker-rsync-scheduler and tautulli-remap.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns off digest pinning in two places where Renovate cannot keep a pinned line in step with its copy.
docs/*.mdcustom manager can move a tag but cannot write a digest. The Traefik bump in chore(deps): update traefik docker tag to v3.7.14 docs#9 pinned a digest in the example files only, so the snippet check failed on main.docs/*.mdcustom manager in every repo: its matchString has no digest group, so its pin updates can never be applied. The groupedrenovate/pin-dependenciesbranch errors on every run in cplieger/docs, docker-fclones-scheduler, docker-rsync-scheduler and tautulli-remap.Tested with Renovate 44.140.0:
renovate-config-validatorpasses, and a local--dry-run=lookupon a tree shaped like cplieger/docs shows tag-only patch updates with nopinDigestupdate for the examples, the test compose files and the page copies. Outside cplieger/docs, compose files keep their digest pins and only the page lines lose them.