Repository navigation
fix: drop image digests so the guide copies match the examples - #10
Merged
Merged
Conversation
The Traefik bump pinned a digest in the two Traefik example files but not in their copies in docs/reverse-proxy.md and docs/proxy-login.md, so the snippet check failed on main. Every image line in the repo now uses a plain tag, the test images included: the examples are what a reader copies, and the example tests run current tags.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Traefik bump in #9 pinned a digest in the two Traefik example files but not in their copies in
docs/reverse-proxy.mdanddocs/proxy-login.md, soscripts/snippets.py --checkfailed on the PR and on main.This removes the digests, so every image line in the repo uses a plain tag. That includes the four test files that picked up a Python digest in #6. The examples are what a reader copies, and the guide recommends a tag that keeps updating. The example tests run current tags on purpose. The org Renovate preset stops pinning digests in this repo in cplieger/.github#265, so the same bump will not happen again.
python3 scripts/snippets.py --checkpasses locally.