Repository navigation
Terminal: no "not running" line over the grid (#745, D290) - #748
Merged
Merged
Conversation
…the state (#745, D290)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #745
Change
internal/app/frame.go:TerminalNotRunningLineand theNotRunningcase ofterminalLineare gone. The grid stays and is dimmed (staleOpacity) while the connection is not live. That check is nowgridDimmed(), so tests can check it. The "terminal unavailable" and incompatible-core lines stay.TestTerminalLinesUseTheirTokensnow checks that no line shows and the grid is dimmed. The new testTestAnEndedTerminalShowsADimmedGridAndNoLinecovers the drawn slot. The "finished" case leftTestTerminalSlotShowsWhyItIsNotRunning. The hidden-window test waits for the state, not the line.New shell tab in NotRunning
I did not fix this; the cause is not proven. See the PR comment / report:
Conn.attachFailedsets NotRunning fornot_found/finished/machine_unknownand gives up until a "restarted" event. It sets NotRunning with a retry for any other attach error or a stream that ends. A fresh grid draws a cursor even with no output, so a failed first attach looks like a live tab.Pre-check
TestAnEndedTerminalShowsADimmedGridAndNoLineandTestTerminalLinesUseTheirTokensfailed.buildTerminalthroughgridDimmed.scripts/check.sh: ok.