Repository navigation
Chat: chips and links are ink with an underline; a worker chip shows its model mark (#747, D292) - #752
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #747
What changed
tstext), tinted byWorkerInk(needs youink-100, workingink-88, elseink-30). Another program: no icon. The family travels in the chip address (contr-chip:worker.claude/...);WorkerChiptakes the profile's model, whichchatChipsgets fromdeps.ModelOf, as the notes do. No file reads.Linkcolor is nowink-88(the text's ink). The pre-pass wraps chip text and the text of Markdown links ([text](url)) in<u>, so all links in an answer are ink with an underline. Icons keep their state color.docs/spec/ChatView.md(Claude's text, Chips), D292; D275, D285, D286, D288 marked.Deviations
ink-88), not a lower step: MyGo's markdown has no decoration color for links (ui.Span.DecorationColoris not reachable frommarkdown.Theme). A lower step needs a MyGo change.https://…,<https://…>) get no resting underline: tags around them end the autolink. They are ink and underline on hover (MyGo's link).ink-100.Tests
go test ./internal/app/chatview ./internal/app;scripts/check.sh: ok.scripts/sheet.sh ChatViewChips, both themes checked.Pre-check
<u>off), TestChipIcon (worker mark off), TestWorkerChipFamily (family off; family not in dest), TestLinksHaveTheLinkColor (content-link back), TestChatChipsKnowWorkersByName (profile model off).ChipColorandchipDotstay for the board's worker rows.