Skip to content

Chat: chips and links are ink with an underline; a worker chip shows its model mark (#747, D292) - #752

Merged
contursofran merged 2 commits into
mainfrom
agent/747-chip-look
Nov 11, 2026
Merged

contursofran merged 2 commits into
mainfrom
agent/747-chip-look

Conversation

@contursofran

Copy link
Copy Markdown
Owner

Fixes #747

What changed

  • Worker chip: no dot. It shows the mark of its model family (Claude, OpenAI, DeepSeek; D285), the size of the PR chip's Octicon (0.9 of ts text), tinted by WorkerInk (needs you ink-100, working ink-88, else ink-30). Another program: no icon. The family travels in the chip address (contr-chip:worker.claude/...); WorkerChip takes the profile's model, which chatChips gets from deps.ModelOf, as the notes do. No file reads.
  • Chip and link text: the markdown Link color is now ink-88 (the text's ink). The pre-pass wraps chip text and the text of Markdown links ([text](url)) in <u>, so all links in an answer are ink with an underline. Icons keep their state color.
  • Docs: docs/spec/ChatView.md (Claude's text, Chips), D292; D275, D285, D286, D288 marked.

Deviations

  • The underline is in the text's ink (ink-88), not a lower step: MyGo's markdown has no decoration color for links (ui.Span.DecorationColor is not reachable from markdown.Theme). A lower step needs a MyGo change.
  • Bare URLs (https://…, <https://…>) get no resting underline: tags around them end the autolink. They are ink and underline on hover (MyGo's link).
  • Hover keeps MyGo's link hover (pointer and its underline); the underline does not rise to ink-100.
  • The mark in a chip does not hop while the worker works (an inline object, drawn once per frame of text).

Tests

  • go test ./internal/app/chatview ./internal/app; scripts/check.sh: ok.
  • Sheet: scripts/sheet.sh ChatViewChips, both themes checked.
  • No e2e test covers chat chips.

Pre-check

  1. Tests, each seen failing with the change undone: TestLinksAreUnderlined (Labels off), TestChipTextRewritesOnlyKnownNames (<u> off), TestChipIcon (worker mark off), TestWorkerChipFamily (family off; family not in dest), TestLinksHaveTheLinkColor (content-link back), TestChatChipsKnowWorkersByName (profile model off).
  2. Plan: steps 1–3 done; deviations above.
  3. Contract: no contract section; D292 as asked.
  4. Up to date with main. Open PR Terminal: no "not running" line over the grid (#745, D290) #748 adds D290 to DECISIONS.md: a small conflict at the end of the table is likely.
  5. Diff read: no leftovers.
  6. Issue lines: all done; bare URLs underline on hover only.
  7. Duties: the worker dot in chips is removed on purpose; ChipColor and chipDot stay for the board's worker rows.
  8. Sheets made after the last code change.

@contursofran
contursofran marked this pull request as ready for review November 11, 2026 22:35
@contursofran
contursofran merged commit 5f2a608 into main Nov 11, 2026
2 checks passed
@contursofran
contursofran deleted the agent/747-chip-look branch November 11, 2026 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Chat chips: a worker chip shows its model mark, and chip text is ink with an underline

1 participant