Repository navigation
Chat: brand marks of known servers on call lines (#709 S4, D274) - #734
Merged
Merged
Conversation
A connector, plugin or other MCP call of a known server shows the monochrome Simple Icons mark of the server in ink-48 in place of the kind icon. One table in chatview/tools.go maps the server name.
…o agent/709-brand-marks
This was referenced Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #709 (S4, brand marks, option C).
Steps
assets/icons/brands/; embed them;icons.Brand(name).chatview/tools.go: onebrandstable;brand()ignores case, spaces/_/-, and the prefixesclaude.ai,claude_ai_,plugin_<plugin>_(tries each tail, soplugin_design_google_calendarworks).ink-48), labeltool icon brand <name>; an unknown server keeps the kind icon.docs/spec/ChatView.mdextended.CallLinesBrands(9 servers, one unknown); see.shchat-toolsfixture gets a Notion connector and an unknownacmeserver (12 calls).Marks: Slack, Notion, Gmail, Google Calendar, Google Drive, GitHub, Linear, Figma, Mixpanel, Spotify, Jira, Atlassian, Datadog, Intercom. Simple Icons has all 14, so none is missing.
Tests
TestBrand(prefixes, case, unknown, plugin tails),TestCallLineBrand(Notion mark; unknown keepsconnector),TestBrandMarks(each mark embeds and parses),TestCallLineIconupdated.TestChatCallDetail(count updated to 12): pass.scripts/check.sh: ok.Pre-check
TestCallLineBrandandTestCallLineIconfailed. With case and prefix handling undone,TestBrandfailed.e2e_see_test.go,DECISIONS.mdandChatView.md(Chat: the composer shows Claude Code's suggested next prompt (#727, D281) #733 alsosheet_test.go), probably in other hunks.chat-toolsin Dark and Light and the sheetCallLinesBrands, taken after the final code change.