Repository navigation
Chat: GitHub Octicons for PR and issue chips (#714 B, D286) - #737
Merged
Merged
Conversation
A connector, plugin or other MCP call of a known server shows the monochrome Simple Icons mark of the server in ink-48 in place of the kind icon. One table in chatview/tools.go maps the server name.
…o agent/709-brand-marks
A worker of the Claude, OpenAI or DeepSeek family shows its mark in place of its 6px dot, in the dot's ink, and hops while it works. Another program keeps the dot. Adds the OpenAI and DeepSeek marks of Simple Icons.
PR chips and the board's PR cell show the pull request Octicon of their state (open, draft, merged, closed); issue chips show the issue Octicon (open, closed). The icons are drawn in ink-48. The read of a number adds isDraft. NOTICE credits Octicons (MIT).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #714 (slice B: GitHub icons).
Steps
assets/icons/github; credit them in NOTICE.icons.GitHub: state-to-icon map (PRIcon,IssueIcon),GitHubSVG,GitHubIcondrawn in an ink token.gh pr viewof a number (RefState) addsisDraft;github.Ref.Draft. No new gh read.ink-48, then the checks dot (running, passed, failed). An issue chip shows the open or closed issue Octicon. The chip address carries "pr.draft"; the tip says "Draft PR #n".A number that contr does not know stays plain text, so no icon shows (as before).
Not done
viewers/boardwork.go) are hidden behind D147 and their label column is 52px; I did not add an icon there.Tests
icons: TestPRIconMap, TestIssueIconMap, TestEveryGitHubIconLoads.chatview: TestChipGitHub (each kind and state), TestChipIcon (each PR and issue state), TestDraftChipDest, TestChipStates (draft, closed issue), TestBoardPRIcons (board view: draft and merged icons).github: TestRefStateOfAPullRequest readsisDraft.Pre-check
chat-pathsfixture the merge made.