Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.github/workflows/ci.ymlalready exists here and already builds, tests and packs on every pull request. What it does not do is produce a status check namedci— and that is exactly what the organisation rulesetcontext-and-oss-required-cirequires onmainandrelease/**.GitHub names a check run after the job key (or its
name:, when one is set) — never after the file name or the workflowname:. This repo therefore emits:and the ruleset waits for a check called
cithat nothing ever produces. On #22 the only check listed isrun-ci. BecauseTeam ContextAndis a bypass actor on that ruleset, our own PRs merge regardless and the missing check shows up as a warning; for an outside contributor it is a hard stop.The change
Two lines. Workflow
name:Check PR→CI, and job keyrun-ci→ci. Every step is untouched, so the build does exactly what it did before — only the name of the check changes.After merge the check list on a PR here reads
ci, and the ruleset requirement is satisfied instead of pending.Why the comment above the job
ciis a contract with the ruleset, not a preference. Aname:on the job, astrategy.matrix(which renames the check toci (x)), or anif:that can skip the job on a pull request would each silently break the required check again, so the constraint is written next to the thing it constrains.Context
None of the 17 repositories in
context-and-osscurrently emits a check namedci; several also have a default branch that is notmain. This is the reference PR for the rest of the rollout — the same two-line shape covers XrmMockup, XrmSync, DataverseQuery, DataverseAnalyzer and DataverseConnection; repos with several parallel jobs (XrmBedrock, DataModelViewer, xrm-emulator) instead keep their jobs and add a fan-incijob.The standard is written down in engx: Repository Requirements ("Continuous Integration") and Rulesets.