Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+54
to
+67
| needs: [generator, website] | ||
| if: always() | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Fail if any CI job did not succeed | ||
| run: | | ||
| set -euo pipefail | ||
| echo "generator=${{ needs.generator.result }} website=${{ needs.website.result }}" | ||
| for result in "${{ needs.generator.result }}" "${{ needs.website.result }}"; do | ||
| if [[ "$result" != 'success' ]]; then | ||
| echo "::error::A required CI job did not succeed ($result)." | ||
| exit 1 | ||
| fi | ||
| done |
This was referenced Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every PR in this repo shows this, and it never resolves:
The org ruleset
context-and-oss-required-cirequires a status check namedci. GitHub names a check run after the job key (or itsname:, when one is set) — never after the file name or the workflowname:. This repo's workflow is already titledCI, but its jobs are keyedgeneratorandwebsite, so those are the two checks it emits. Nothing ever reportsci, so the row waits forever.The change
ci-pipeline.yml→ci.yml(file rename only; nothing referenced the old name)cithat runs nothing — it just waits forgeneratorandwebsiteand fails unless both succeededBoth existing jobs and every step in them are untouched.
if: always()makes the gate report even when an upstream job failed, and the step then turns that into a red check, sociis green exactly when the real work is green.A fan-in job is used here rather than renaming one of the existing jobs, because a required check can only be one name and this repo legitimately has two parallel builds.
After merge
New PRs get a real
cirow instead of the waiting one. Already-open PRs pick it up on their next push — the check list is built per commit, so existing commits are not re-evaluated retroactively.The release workflows are untouched and stay separate; they are never the required check.
Context
None of the 17 repos in
context-and-ossemitscitoday — this is part of fixing that everywhere. Reference PR for the simple case (a plain job rename): XrmPluginCore#23. Standard: Repository Requirements.