Repository navigation
chore: use quality-runners instead of GitHub Actions - #17
Conversation
CI workflow is a pointer only. Pint, Pest, PHPStan, and Rector run locally via ./bin/ci and on PRs via synapse-sentinel/quality-runners.
|
Local |
The pointer job was green without executing tests. Residual GHA still runs Pint --test and Pest. It is not named quality-runners/gate.
|
Correction: quality-runners does run Pest (plus Pint/PHPStan/Rector) — on the clone host, not on |
There was a problem hiding this comment.
PR replaces the Actions CI job with a quality-runners stub and adds the four-tool local gate plus supporting config/tests. Matches the stated intent exactly.
- ci.yml now only declares the house gate is quality-runners and runs a residual Pint/Pest pair (no fake-green job name).
- bin/ci, phpstan.neon, rector.php, and QualityRunnersCiTest.php all present and passing locally per the checklist.
- Style/consistency edits (concat spacing, import shortening, arrow fn) are uniform across touched files.
No blocking issues. Ready for #73 to land the real gate status.
Why
House quality is quality-runners (Pint, Pest, PHPStan, Rector), not GitHub-hosted Actions. This repo was still installing Composer and running Pest in
ci.yml, which is a second runner and not thequality-runners/gatestatus merge reads.Do
.github/workflows/ci.ymlwith the same pointer job Asgard / Prefrontal ship (quality-runners is the house gate). It does not checkout, does not install, does not run the tools, and does not fake-green a check namedPint + PHPStan + Pest../bin/cifor the worktree gate.synapse-sentinel/gateActions workflow.Do not
quality-runners/gateyet. This change stops Actions from pretending it is the gate.Done when
./bin/ciexits 0 locallyci.ymlcontainsquality-runners is the house gateand does not containvendor/bin/pestgh api repos/conduit-ui/cloudflare/commits/<head>/statusshowsquality-runners/gate