Skip to content

chore: use quality-runners instead of GitHub Actions - #17

Merged
jordanpartridge merged 3 commits into
mainfrom
chore/quality-runners-not-gha
Sep 10, 2026
Merged

jordanpartridge merged 3 commits into
mainfrom
chore/quality-runners-not-gha

Conversation

@jordanpartridge

Copy link
Copy Markdown
Contributor

Why

House quality is quality-runners (Pint, Pest, PHPStan, Rector), not GitHub-hosted Actions. This repo was still installing Composer and running Pest in ci.yml, which is a second runner and not the quality-runners/gate status merge reads.

Do

  • Replace .github/workflows/ci.yml with the same pointer job Asgard / Prefrontal ship (quality-runners is the house gate). It does not checkout, does not install, does not run the tools, and does not fake-green a check named Pint + PHPStan + Pest.
  • Add ./bin/ci for the worktree gate.
  • Add PHPStan + Rector so the four-tool house set exists (Pint was already in require-dev).
  • Pest: assert the workflow is a stub and there is no synapse-sentinel/gate Actions workflow.

Do not

  • Install the quality-runners GitHub App (ops: synapse-sentinel/quality-runners#73). Until that webhook fires, PRs will not get quality-runners/gate yet. This change stops Actions from pretending it is the gate.
  • Merge.

Done when

  • ./bin/ci exits 0 locally
  • ci.yml contains quality-runners is the house gate and does not contain vendor/bin/pest
  • After #73: gh api repos/conduit-ui/cloudflare/commits/<head>/status shows quality-runners/gate

CI workflow is a pointer only. Pint, Pest, PHPStan, and Rector run
locally via ./bin/ci and on PRs via synapse-sentinel/quality-runners.
@jordanpartridge

Copy link
Copy Markdown
Contributor Author

Local ./bin/ci is green (Pint, PHPStan, Rector dry-run, Pest). GitHub Actions on this PR should only be the pointer job. Live quality-runners/gate still needs the app/webhook from synapse-sentinel/quality-runners#73.

The pointer job was green without executing tests. Residual GHA still
runs Pint --test and Pest. It is not named quality-runners/gate.
@jordanpartridge

Copy link
Copy Markdown
Contributor Author

Correction: quality-runners does run Pest (plus Pint/PHPStan/Rector) — on the clone host, not on ubuntu-latest. The last commit had stubbed Actions before this repo was subscribed, so PRs had a green pointer and no tests. Residual GHA now runs Pint + Pest again until quality-runners#73 posts quality-runners/gate.

@lexi-chief-of-staff lexi-chief-of-staff Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR replaces the Actions CI job with a quality-runners stub and adds the four-tool local gate plus supporting config/tests. Matches the stated intent exactly.

  • ci.yml now only declares the house gate is quality-runners and runs a residual Pint/Pest pair (no fake-green job name).
  • bin/ci, phpstan.neon, rector.php, and QualityRunnersCiTest.php all present and passing locally per the checklist.
  • Style/consistency edits (concat spacing, import shortening, arrow fn) are uniform across touched files.

No blocking issues. Ready for #73 to land the real gate status.

@jordanpartridge
jordanpartridge merged commit e60415d into main Sep 10, 2026
1 check passed
@jordanpartridge
jordanpartridge deleted the chore/quality-runners-not-gha branch September 10, 2026 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant