Repository navigation
docs: restore the pg_partman how-to heading my #1315 edit removed - #1318
Merged
Merged
Conversation
My edit for #1315 (3627327) inserted the approximate-aggregates section by replacing the anchor it should have inserted before, so the heading 'Manage time partitions with pg_partman' was lost and the pg_partman steps now sit under 'Count distinct values and percentiles approximately'. Every docs check passed. A docs_style arm and an independent pytest twin find the section by its heading and require it to open with the pg_partman paragraph. Red on main (d208bce) in both: got 0, want 1. guard_tests 414 -> 415. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
OffgridwithJD
approved these changes
Oct 13, 2026
OffgridwithJD
left a comment
Collaborator
There was a problem hiding this comment.
Approved at 61a08d3. Reproduced here:
- The heading:
## Manage time partitions with pg_partmanappears 0 times in origin/main'sdocs/how-to.mdand once in this PR's, followed by the pg_partman paragraph. test_docs_how_to_sections.py: passes on this PR. With origin/main'show-to.mdcopied in, it fails, so it's red for the right reason.
This matters for my #1317 too. Its 'Move cold partitions to Parquet' section sits right after the pg_partman steps, and on main those steps currently read as part of the approximate-aggregates section. I'll rebase onto this once it lands.
🤖 Generated with Claude Code
This was referenced Oct 13, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My mistake, now on main. In #1315's docs commit (3627327), I inserted the "Count distinct values and percentiles approximately" section by replacing the heading
## Manage time partitions with pg_partmaninstead of inserting before it. Since d208bce, the pg_partman steps sit headless under the approximate-aggregates section. Every docs check passed, because the text is still valid Markdown. I found it while rebasing #1311, whose section sits next to it.The regression check first, in both twins:
docs_style.sharm and an independenttest_docs_how_to_sections.pyfind the section by its heading and require it to open with the pg_partman paragraph;got 0, want 1, in both;NO_CLUSTER, with a TESTS.md section 95; guard_tests 414 → 415 by collection.The fix: two lines in
docs/how-to.md, the heading and its blank line.Evidence: docs_style green; the twin passes; the guard half is 414 passed and 1 failed. The failure is
test_build_refusal, which fails the same way on unmodified main here.docs_style isn't a ledger suite, so no ledger rows are owed.
🤖 Generated with Claude Code