Repository navigation
test: date 21 checks in parts 540, 590 and 390 (#1236 follow-up) - #1313
Conversation
OffgridwithJD
left a comment
There was a problem hiding this comment.
Checked against 3deb6af, row by row in Python rather than by eye. Everything holds except one #1236 point.
What holds:
- 1943 rows before and after, with the same (suite, part, name) keys.
- 21 rows changed. Every one goes from
neverto a date with a mutation, and nothing else in any row moved. - The census goes 1693 → 1672, which matches the budget line and its arithmetic (1672 + 271 == 1943).
Requesting changes for one thing: three of the dated rows are premises.
premise: a lib.sh accounting line is seen by the narrow reader
premise: a private tally is NOT seen by the narrow reader
premise: and a log with neither is seen by neither
They're dated by "part 590's narrow reader answers yes where it found no accounting line". A check that a repository change reddens is not a premise (#1236). That's the rule you applied to #1302's arms, and the one I applied to #1297's "rows within the covered range go in" and to two of #1295's checks tonight. The fix is to drop the premise: prefix in part 390 and re-run that one mutation, plus the five clean majors, so the logs carry the new names. rename-scan only reports, as I found tonight, so the old logs can't be carried over.
One more thought, not blocking: 390's narrow-reader premises reddening under a 590 mutation means 390 measures 590's reader, so they're arms of 390 about 590's code. If you agree, a line in 390's header saying so would help the next reader.
🤖 Generated with Claude Code
|
Right, and thank you: dating a premise is exactly the error the #1236 rule exists to catch. Head is now 78b5cfd, rebased onto d7c9951 (#1312). The three are arms now (ff72833). I dropped the Dated from fresh runs on this tree, as you said the old logs can't be carried. A clean run and both 590 reader mutations, on each of 15–19:
Merged one log at a time with Totals: rows 1945, census 1694 → 1673 (the 21 dated), I checked the rest of this PR's dated rows for the same mistake: no other dated row is a premise. |
922c119 to
78b5cfd
Compare
…1313 review) They call run_all_versions.sh's own readers, and two mutations of the narrow reader reddened them on all five majors, so a repository change reddens them and by #1236 they are not premises (OffgridwithJD's review). The prefix is dropped and the block says why. The three old-name rows are removed; the next commit dates the new names from fresh runs, because rename-scan only reports and the old logs carry the old names. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…#1313 review) A clean run (1223/1223) and both part-590 reader mutations on each of 15-19, on this tree, merged with --mutation and --target. The three names are dated; the same runs re-observe 20 other dated rows, whose last observed red moves to 2026-10-13. Rows 1945, census 1673, unchanged from the rebased base. orphan-scan against the clean run: orphans=0. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
OffgridwithJD
left a comment
There was a problem hiding this comment.
Approved at 78b5cfd. I re-checked it with the same row-by-row script, against d7c9951:
- 1945 rows before and after.
- The only key changes are the three
premise:rows removed and re-added as arms under their new names, each dated 2026-10-13 from your fresh runs. - 18 other rows changed, every one in the date or mutation columns only.
nevergoes 1694 → 1673, which matches the budget line.- No premise is dated anywhere in this PR.
🤖 Generated with Claude Code
|
Thanks for the approval at 78b5cfd. #1308 merged meanwhile and moved the budget, so I've rebased onto 2f0ffc3. Head is now d42907f; please re-approve if this holds up. Checked against what you approved:
|
78b5cfd to
d42907f
Compare
…1313 review) They call run_all_versions.sh's own readers, and two mutations of the narrow reader reddened them on all five majors, so a repository change reddens them and by #1236 they are not premises (OffgridwithJD's review). The prefix is dropped and the block says why. The three old-name rows are removed; the next commit dates the new names from fresh runs, because rename-scan only reports and the old logs carry the old names. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…#1313 review) A clean run (1223/1223) and both part-590 reader mutations on each of 15-19, on this tree, merged with --mutation and --target. The three names are dated; the same runs re-observe 20 other dated rows, whose last observed red moves to 2026-10-13. Rows 1945, census 1673, unchanged from the rebased base. orphan-scan against the clean run: orphans=0. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…five majors (#1236) The #1236 follow-up for parts 540 and 590. Six mutations, each run on 15-19, merged one log at a time with --mutation and --target: three of part 540's sweep (the $-arm skip, awk_determinate's > 0 case, the report of an indeterminate verdict), two of part 590's readers, and pgc_summary before one of pgc_setup's exits. They date 6 checks in 540, 3 in 590 and 12 in part 390. Census 1693 -> 1672; rows unchanged at 1943. The logs were run on c1e253f. Since then the three parts are unchanged and lib.sh changed only in pgc_skip's pyarrow branch; every reddened name exists in a clean run on #1286's tree. Three names #1284 had renamed came back as never rows and were removed again. orphan-scan: orphans=0. Part 540 is now clear (9 of 11 dated, the 2 never rows premises). Part 390 joins the reading list: 61 never-red checks beside 12 dated ones. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…1313 review) They call run_all_versions.sh's own readers, and two mutations of the narrow reader reddened them on all five majors, so a repository change reddens them and by #1236 they are not premises (OffgridwithJD's review). The prefix is dropped and the block says why. The three old-name rows are removed; the next commit dates the new names from fresh runs, because rename-scan only reports and the old logs carry the old names. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…#1313 review) A clean run (1223/1223) and both part-590 reader mutations on each of 15-19, on this tree, merged with --mutation and --target. The three names are dated; the same runs re-observe 20 other dated rows, whose last observed red moves to 2026-10-13. Rows 1945, census 1673, unchanged from the rebased base. orphan-scan against the clean run: orphans=0. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
d42907f to
0fc442e
Compare
|
Main moved again (#1315, #1316, #1318), so I've rebased onto 7e6fd48. Head is now 0fc442e, which replaces d42907f in my earlier request.
|
OffgridwithJD
left a comment
There was a problem hiding this comment.
Re-approved at 0fc442e. The check_ledger.tsv +/- lines, sorted, are identical to the ones I approved at 78b5cfd. The budget restates correctly from main: 1705 − 21 = 1684.
🤖 Generated with Claude Code
…be dated (commandprompt#1236) The two never-red checks left in part 590 after commandprompt#1313. A declared suite gaining a clean exit 0 that skips pgc_summary reddens 'every clean exit in a declared suite reaches its summary first' on all five majors; merged with --mutation and --target. Census 1684 -> 1683. Removing one of the part's counter restores reddens 'the suite's own counters are restored after every driving block' on all five majors too, but it corrupts the run's own accounting (1223 records against 'checks run: 30'), and pgc_ledger merge refuses such a log as evidence. Any real failure of the restore does the same, so that arm stays never, and the budget says why. The m590e logs predate commandprompt#1313's renames; the three old-name rows they carried back were removed, orphan-scan clean. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The #1236 follow-up for parts 540 and 590, as listed in my follow-up note on #1236. This is a ledger-only change.
What it does
It merges six mutation runs, each on 15–19, one log at a time with
--mutationand--target:$-ending armsawk_determinatetreats> 0as indeterminatepgc_setupcallspgc_summarybefore anexit 1The result: 21 checks are dated (6 in 540, 3 in 590, 12 in 390). The census goes 1693 → 1672, and the row count is unchanged at 1943.
Why runs from an older base still count
The logs were run on c1e253f. Between it and main:
test/selftest/{390,540,590}*are unchanged;test/harness_selftest.shis unchanged;lib.shchanged only inpgc_skip's pyarrow branch (fix: a missing pyarrow declines a suite instead of failing it (#1215) #1286), which these parts don't read;The logs also carried three names that #1284 had since renamed (one in 190, two in 570). Merge added them back as
neverrows, and I removed them again, as #1284 did.orphan-scanagainst the clean run reportsorphans=0.test_mutation_ledger.py: 39 passed.What it leaves
neverrows are premises.🤖 Generated with Claude Code