Repository navigation
test: date part 590's clean-exit arm; its counter-restore arm cannot be dated (#1236) - #1320
Merged
Merged
Conversation
…be dated (#1236) The two never-red checks left in part 590 after #1313. A declared suite gaining a clean exit 0 that skips pgc_summary reddens 'every clean exit in a declared suite reaches its summary first' on all five majors; merged with --mutation and --target. Census 1684 -> 1683. Removing one of the part's counter restores reddens 'the suite's own counters are restored after every driving block' on all five majors too, but it corrupts the run's own accounting (1223 records against 'checks run: 30'), and pgc_ledger merge refuses such a log as evidence. Any real failure of the restore does the same, so that arm stays never, and the budget says why. The m590e logs predate #1313's renames; the three old-name rows they carried back were removed, orphan-scan clean. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
OffgridwithJD
approved these changes
Oct 13, 2026
OffgridwithJD
left a comment
Collaborator
There was a problem hiding this comment.
Approved at 9e91089. Checked row by row against 953c192:
- 1984 rows, keys unchanged. Exactly one row changed:
every clean exit in a declared suite reaches its summary first, from never to 2026-10-13, dated by the injected-exit mutation. never1684 → 1683, matching the budget. No premise touched.
On the counter-restore arm: agreed that it can't be dated. A mutation that breaks what the arm detects also breaks the log's self-reconciliation, so merge correctly refuses that log as evidence. Recording that in the budget is the right place.
🤖 Generated with Claude Code
This was referenced Oct 13, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last two never-red checks in part 590, after #1313. This is a ledger-only change.
ttl_expire.shgains[ -n "${PGC_NEVER_SET_1236:-}" ] && exit 0beforepgc_summarygot [1] want [0]); dated_da_put "$_da_sv"removedgot [no yes yes]), but not datableWhy the second can't be dated. The defect the check detects corrupts the run's own counters. The log then shows 1223 records against
checks run: 30, andpgc_ledger mergerefuses it ("the log does not reconcile with itself, so it is not evidence"). That refusal is correct, and any real failure of the restore does the same. So it staysnever, and the budget explains why, so the #1236 reading list doesn't keep re-raising it.Ledger:
premise:names; I removed those rows again.orphan-scanagainst a clean run with today's names:orphans=0.test_mutation_ledger.py: 39 passed.🤖 Generated with Claude Code