Skip to content

Added Action Identifier #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raphael-goetz merged 5 commits into from
Jan 23, 2026
+10 −0
Merged

Added Action Identifier #199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3359e59
feat: added action identifier
raphael-goetz Jan 18, 2026
9bd9406
ref: fixed typo
raphael-goetz Jan 18, 2026
e48a799
Update proto/shared/shared.flow.proto
raphael-goetz Jan 18, 2026
e97f6e8
Update proto/shared/shared.runtime_function.proto
raphael-goetz Jan 18, 2026
4e0cedc
Update proto/shared/shared.flow_definition.proto
raphael-goetz Jan 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions proto/shared/shared.data_type.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@ message DefinitionDataType {
// Version of the data type
// Format: "major.minor.patch", e.g. "1.2.3"
string version = 8;
// Field will be set by an action to distinguish an action function from a runtime function
optional string action_identifier = 9;
}

message ExecutionDataType {
Expand Down
4 changes: 4 additions & 0 deletions proto/shared/shared.flow.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,12 +46,16 @@ message NodeFunction {
string runtime_function_id = 2;
repeated NodeParameter parameters = 3;
optional int64 next_node_id = 4;
// Identifier of the action that can execute this function
// If not present it should be a runtime function
optional string action_identifier = 5;
Copy link
Contributor

@nicosammito nicosammito Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about an action version? Because maybe it's possible to connect two actions just from a different version? Or do they have different identifiers then, because the user has to provide a identifier them self?

Copy link
Member Author

@raphael-goetz raphael-goetz Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not possible to connect the same action with different versions to the same runtime

Copy link
Contributor

@nicosammito nicosammito Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But this can't be true. Of course it should be possible to connect the same action just with different versions to the runtime over a different identifier.

Copy link
Contributor

@nicosammito nicosammito Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But yeh my question is not absolute, because yes the identifier is just different for the same action with a different version.

Copy link
Member Author

@raphael-goetz raphael-goetz Jan 23, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the identifier is different it will be registered as a whole new action. But if just the version changed and not the identifier it will be registered as a new version and would overwrite all definitions of the still connected action. This can't happen

Copy link
Contributor

@nicosammito nicosammito Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep this was my confusion. You can connect the same action twice, you just need to provide a different identifier.

}

message NodeValue {
oneof value {
shared.Value literal_value = 1;
ReferenceValue reference_value = 2;
// Reference to the `database_id` field of message `NodeFunction`
int64 node_function_id = 3;
}
}
Expand Down
2 changes: 2 additions & 0 deletions proto/shared/shared.flow_definition.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@ message FlowType {
// Format: "major.minor.patch", e.g. "1.2.3"
string version = 11;
string display_icon = 12;
// Field will be set by an action to distinguish an action function from a runtime function
optional string action_identifier = 13;
}

message FlowTypeSetting {
Expand Down
2 changes: 2 additions & 0 deletions proto/shared/shared.runtime_function.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@ message RuntimeFunctionDefinition {
// Format: "major.minor.patch", e.g. "1.2.3"
string version = 12;
string display_icon = 13;
// Field will be set by an action to distinguish an action function from a runtime function
optional string action_identifier = 14;
}

// Definition of a parameter used for execution
Expand Down