Added Action Identifier #199
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request adds an action_identifier field to multiple protobuf message definitions to distinguish action functions from runtime functions, resolving issue #195.
Changes:
- Added optional
action_identifierstring fields to four protobuf messages - Added documentation comments explaining the purpose of the new fields
- Added a clarifying comment in
NodeValuemessage about thenode_function_idfield
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| proto/shared/shared.runtime_function.proto | Added action_identifier field to RuntimeFunctionDefinition message |
| proto/shared/shared.flow_definition.proto | Added action_identifier field to FlowType message |
| proto/shared/shared.flow.proto | Added action_identifier field to NodeFunction message and clarifying comment for node_function_id |
| proto/shared/shared.data_type.proto | Added action_identifier field to DefinitionDataType message |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
raphael-goetz
force-pushed
the
195-add-action-identifier
branch
from
9e07ec8 to
9bd9406
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Raphael Götz <52959657+raphael-goetz@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Raphael Götz <52959657+raphael-goetz@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Raphael Götz <52959657+raphael-goetz@users.noreply.github.com>
| optional int64 next_node_id = 4; | ||
| // Identifier of the action that can execute this function | ||
| // If not present it should be a runtime function | ||
| optional string action_identifier = 5; |
There was a problem hiding this comment.
what about an action version? Because maybe it's possible to connect two actions just from a different version? Or do they have different identifiers then, because the user has to provide a identifier them self?
There was a problem hiding this comment.
It's not possible to connect the same action with different versions to the same runtime
There was a problem hiding this comment.
But this can't be true. Of course it should be possible to connect the same action just with different versions to the runtime over a different identifier.
There was a problem hiding this comment.
But yeh my question is not absolute, because yes the identifier is just different for the same action with a different version.
There was a problem hiding this comment.
If the identifier is different it will be registered as a whole new action. But if just the version changed and not the identifier it will be registered as a new version and would overwrite all definitions of the still connected action. This can't happen
There was a problem hiding this comment.
Yep this was my confusion. You can connect the same action twice, you just need to provide a different identifier.
Resolves: #195