Skip to content

test(adapters/app): expect the jobs default next to an empty dry-run - #616

Merged
jeefy merged 1 commit into
cncf:mainfrom
jeefy:fix/webhook-guards-jobs-default
Oct 29, 2026
Merged

jeefy merged 1 commit into
cncf:mainfrom
jeefy:fix/webhook-guards-jobs-default

Conversation

@jeefy

@jeefy jeefy commented Oct 29, 2026

Copy link
Copy Markdown
Member

One expectation in #612 predates #614's jobs: 'lgtm' default in settingsFromEnv; merged together they fail build-test on main. Verified npm run test:coverage (215 files / 2630 tests, 99.71 lines) and test:coverage:e2e green on main + this.

/kind failing-test

… empty dry-run

cncf#612 was written against 282b8e0, before settingsFromEnv defaulted jobs to
lgtm (cncf#614); merged as-is it fails main's build-test.

Signed-off-by: Jeffrey Sica <me@jeefy.dev>
@jeefy
jeefy requested a review from jpmcb as a code owner October 29, 2026 15:41

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified against the tree, not just the diff:

  • src/adapters/app/settings.ts:45 seeds inputs with { jobs: 'lgtm' } (introduced by #614), so the pre-#614 expectation { 'dry-run': '' } in __tests__/adapters/app/webhookGuards.test.ts:126 cannot pass on current main.
  • Reproduced: npx vitest run __tests__/adapters/app/webhookGuards.test.ts on main fails exactly that one test (1 failed | 9 passed); with this PR's two-line change applied, all 10 pass.
  • The new expectation { 'jobs': 'lgtm', 'dry-run': '' } still exercises the original behaviour under test (an empty-string env value is kept, per the value !== undefined check at settings.ts:48-50), so no coverage is lost.

The PR body's claim matches the code. Looks correct to me — minimal, targeted repair of a cross-PR test conflict.

— hive: agent=reviewer backend=copilot model=claude-fable-5 copilot=1.0.88

@jeefy

jeefy commented Oct 29, 2026

Copy link
Copy Markdown
Member Author

/kind failing-test

@jeefy
jeefy merged commit feed1ba into cncf:main Oct 29, 2026
9 checks passed
@github-actions github-actions Bot added kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. and removed needs-kind labels Oct 29, 2026
mrbobbytables added a commit that referenced this pull request Oct 29, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant