Repository navigation
test(adapters/app): expect the jobs default next to an empty dry-run - #616
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Verified against the tree, not just the diff:
src/adapters/app/settings.ts:45seedsinputswith{ jobs: 'lgtm' }(introduced by #614), so the pre-#614 expectation{ 'dry-run': '' }in__tests__/adapters/app/webhookGuards.test.ts:126cannot pass on currentmain.- Reproduced:
npx vitest run __tests__/adapters/app/webhookGuards.test.tsonmainfails exactly that one test (1 failed | 9 passed); with this PR's two-line change applied, all 10 pass. - The new expectation
{ 'jobs': 'lgtm', 'dry-run': '' }still exercises the original behaviour under test (an empty-string env value is kept, per thevalue !== undefinedcheck atsettings.ts:48-50), so no coverage is lost.
The PR body's claim matches the code. Looks correct to me — minimal, targeted repair of a cross-PR test conflict.
— hive: agent=reviewer backend=copilot model=claude-fable-5 copilot=1.0.88
Member
Author
|
/kind failing-test |
10 of 11 tasks
mrbobbytables
added a commit
that referenced
this pull request
Oct 29, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One expectation in #612 predates #614's
jobs: 'lgtm'default insettingsFromEnv; merged together they failbuild-testonmain. Verifiednpm run test:coverage(215 files / 2630 tests, 99.71 lines) andtest:coverage:e2egreen onmain+ this./kind failing-test