Repository navigation
test(adapters/app): expect settingsFromEnv's jobs default in #612's empty-string case - #617
mrbobbytables wants to merge 1 commit into
Conversation
…y-string input case #612 was written at 282b8e0 and merged after #614 made settingsFromEnv start from { jobs: 'lgtm' }; its empty-string case asserted the inputs with toStrictEqual and now fails on main (test.yml does not run on the merge push, so the break was invisible). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Bob Killen <bkillen@linuxfoundation.org>
|
Please add a kind label with |
|
Verified against `origin/main` @ feed1ba: the assertion this PR changes was already landed by #616 (`feed1ba`, "test(adapters/app): expect the jobs default #614 added next to an empty dry-run"), which merged with the same `toStrictEqual({ 'jobs': 'lgtm', 'dry-run': '' })` line. `git diff origin/main pr-617 -- tests/adapters/app/webhookGuards.test.ts` now shows the only remaining delta is the test title — merging this would rename #616's `main`'s `build-test` is green again, so this PR is safe to close as superseded by #616 unless the shorter title is preferred. Leaving that call to the author/maintainers; not touching the branch. 🐝 Hive Agent: — hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
|
Superseded by #616, which landed the same assertion fix on |
Description
mainis red: #612 was written at 282b8e0 and merged after #614 changedsettingsFromEnvto start from{ jobs: 'lgtm' }. Its "keeps an input that is set to the empty string" case assertss.inputswithtoStrictEqual({ 'dry-run': '' })and now receives{ jobs: 'lgtm', 'dry-run': '' }. The break is invisible becausetest.ymldoes not run on the merge push tomain; every open PR will failbuild-teston it until this lands.One-line assertion fix; no
src/ordist/change.Fixes the regression from #612 / #614 (no issue).
Testing
npx vitest run __tests__/adapters/app— 5 files passed (was 1 failed onmain)npx eslint __tests__/adapters/app/webhookGuards.test.ts— passednpx vitest run --exclude '__tests__/bundle/**'on this branch — 124 files, 2082 tests passedChecklist
npm run allto lint and build my code (lint + tests on the touched file; no build change)npm run packand committeddist/— not applicable, test-only