Skip to content

test(adapters/app): expect settingsFromEnv's jobs default in #612's empty-string case - #617

Closed
mrbobbytables wants to merge 1 commit into
mainfrom
fix/webhook-guards-jobs-default
Closed

mrbobbytables wants to merge 1 commit into
mainfrom
fix/webhook-guards-jobs-default

Conversation

@mrbobbytables

@mrbobbytables mrbobbytables commented Oct 29, 2026 •

Copy link
Copy Markdown
Member

Description

main is red: #612 was written at 282b8e0 and merged after #614 changed settingsFromEnv to start from { jobs: 'lgtm' }. Its "keeps an input that is set to the empty string" case asserts s.inputs with toStrictEqual({ 'dry-run': '' }) and now receives { jobs: 'lgtm', 'dry-run': '' }. The break is invisible because test.yml does not run on the merge push to main; every open PR will fail build-test on it until this lands.

One-line assertion fix; no src/ or dist/ change.

Fixes the regression from #612 / #614 (no issue).

Testing

  • npx vitest run __tests__/adapters/app — 5 files passed (was 1 failed on main)
  • npx eslint __tests__/adapters/app/webhookGuards.test.ts — passed
  • npx vitest run --exclude '__tests__/bundle/**' on this branch — 124 files, 2082 tests passed

Checklist

  • I ran npm run all to lint and build my code (lint + tests on the touched file; no build change)
  • I ran npm run pack and committed dist/ — not applicable, test-only
  • Commits are signed off (DCO)
  • Note any new dependencies these changes bring in — none
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas — n/a
  • I have made corresponding changes to the documentation — n/a
  • My changes generates no new warnings

…y-string input case

#612 was written at 282b8e0 and merged after #614 made settingsFromEnv
start from { jobs: 'lgtm' }; its empty-string case asserted the inputs
with toStrictEqual and now fails on main (test.yml does not run on the
merge push, so the break was invisible).

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Bob Killen <bkillen@linuxfoundation.org>
@github-actions

Copy link
Copy Markdown
Contributor

Please add a kind label with /kind feature, /kind failing-test or /kind cleanup.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Verified against `origin/main` @ feed1ba: the assertion this PR changes was already landed by #616 (`feed1ba`, "test(adapters/app): expect the jobs default #614 added next to an empty dry-run"), which merged with the same `toStrictEqual({ 'jobs': 'lgtm', 'dry-run': '' })` line.

`git diff origin/main pr-617 -- tests/adapters/app/webhookGuards.test.ts` now shows the only remaining delta is the test title — merging this would rename #616's keeps an input that is set to the empty string, next to the jobs default back to the shorter keeps an input that is set to the empty string; no behaviour change either way.

`main`'s `build-test` is green again, so this PR is safe to close as superseded by #616 unless the shorter title is preferred. Leaving that call to the author/maintainers; not touching the branch.


🐝 Hive Agent: quality | Instance: hosted-available-lke648397-260827-5q9t | SHA: 1ce22f0

— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88

@mrbobbytables

Copy link
Copy Markdown
Member Author

Superseded by #616, which landed the same assertion fix on main first.

@mrbobbytables
mrbobbytables deleted the fix/webhook-guards-jobs-default branch October 29, 2026 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant