Repository navigation
docs(coverage): link upstream negative-count branch report - #552
Conversation
Record the reduced reproduction, observed versions and upstream Vitest report without changing defensive code or coverage policy. Hive-Run: #550 Hive-Plan: upstream-v8-negative-count-report Hive-Spec: issue-550#upstream-report Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: mrbobbytables <mrbobbytables@users.noreply.github.com>
|
This PR now conflicts with The only material this PR adds beyond #511 is the upstream link (vitest-dev/vitest#11690) and the environment versions. Suggested rebase: drop the duplicated section and instead add one sentence to the existing #511 section pointing at vitest#11690, e.g. after "A minimal reproduction against Not pushing to this branch since it is not a hive-lane branch. 🐝 Hive Agent: — hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
b5cfe99 to
25c667a
Compare
|
hive-base-moved: rebased onto main at ee398e8. 🐝 Hive Agent: |
Signed-off-by: mrbobbytables <mrbobbytables@users.noreply.github.com>
|
/kind cleanup 🐝 Hive Agent: |
|
Addressed: rebased onto current main, retained the existing #511 section, and added the upstream Vitest issue link plus the reproduction environment versions. 🐝 Hive Agent: |
mrbobbytables
left a comment
There was a problem hiding this comment.
Verified the current diff only extends the existing #511 note with the upstream report and reproduction environment; it no longer duplicates the documentation. The upstream report exists and matches the stated artifact. Focused documentation tests, lint and diff checks passed, as did current build-test, e2e-coverage and DCO. This completes #550. Posting a review comment rather than an approval because this PR is authored by the currently authenticated maintainer.
Description
Closes #550.
Links the existing upstream report vitest-dev/vitest#11690 and its reproduction environment from the coverage note introduced by merged #511.
The updated diff extends that single note rather than adding a duplicate reproduction/recognizer section. The upstream report includes the complete test, configuration, observed negative LCOV count and environment versions. This PR does not change source, tests, dependencies, the bundle or coverage thresholds.
Testing
npx vitest run __tests__/docsYamlExamples.test.ts __tests__/version.test.ts __tests__/configurationDocs.test.ts— passed on the updated branch: 130 passed / 74 skipped across 3 files.npx eslint docs/contributing.mdandgit diff --check— passed.The original contributor reproduced the artifact on Node 24.22.0, Vitest 5.0.4 and coverage-v8 5.0.4: passing test, 75% branches,
BRDA:3,1,1,-2. The documentation review did not repeat that standalone experiment.Checklist
npm run allto lint and build my code — documentation-only change; focused documented checks above were run instead.npm run packand committeddist/— not needed for this documentation-only change.