Skip to content

docs(coverage): link upstream negative-count branch report - #552

Merged
mrbobbytables merged 2 commits into
mainfrom
docs/550-v8-upstream-report
Oct 21, 2026
Merged

mrbobbytables merged 2 commits into
mainfrom
docs/550-v8-upstream-report

Conversation

@mrbobbytables

@mrbobbytables mrbobbytables commented Oct 21, 2026 •

Copy link
Copy Markdown
Member

Description

Closes #550.

Links the existing upstream report vitest-dev/vitest#11690 and its reproduction environment from the coverage note introduced by merged #511.

The updated diff extends that single note rather than adding a duplicate reproduction/recognizer section. The upstream report includes the complete test, configuration, observed negative LCOV count and environment versions. This PR does not change source, tests, dependencies, the bundle or coverage thresholds.

Testing

The original contributor reproduced the artifact on Node 24.22.0, Vitest 5.0.4 and coverage-v8 5.0.4: passing test, 75% branches, BRDA:3,1,1,-2. The documentation review did not repeat that standalone experiment.

Checklist

  • I ran npm run all to lint and build my code — documentation-only change; focused documented checks above were run instead.
  • I ran npm run pack and committed dist/ — not needed for this documentation-only change.
  • Commits are signed off (DCO)
  • Note any new dependencies these changes bring in — none.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas — no production code change.
  • I have made corresponding changes to the documentation
  • My changes generates no new warnings (please describe new warnings if unavoidable)

Record the reduced reproduction, observed versions and upstream Vitest report without changing defensive code or coverage policy.

Hive-Run: #550
Hive-Plan: upstream-v8-negative-count-report
Hive-Spec: issue-550#upstream-report

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: mrbobbytables <mrbobbytables@users.noreply.github.com>
@hivecommons-hive

Copy link
Copy Markdown
Contributor

This PR now conflicts with main: #511 merged (3eb343b) and added a "Phantom "uncovered" branches after an await" section to docs/contributing.md covering the same ground — the gate() reduction, the awk negative-BRDA recognizer, and the "no tests / no ignores / no lower threshold" guidance. git merge-tree --write-tree origin/main b5cfe99 reports a content conflict spanning both hunks of this diff.

The only material this PR adds beyond #511 is the upstream link (vitest-dev/vitest#11690) and the environment versions. Suggested rebase: drop the duplicated section and instead add one sentence to the existing #511 section pointing at vitest#11690, e.g. after "A minimal reproduction against @vitest/coverage-v8 5.0.4:" add "filed upstream as vitest-dev/vitest#11690".

Not pushing to this branch since it is not a hive-lane branch.


🐝 Hive Agent: quality | Instance: hosted-available-lke648397-260827-5q9t | SHA: 3eb343b

— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88

@mrbobbytables
mrbobbytables force-pushed the docs/550-v8-upstream-report branch from b5cfe99 to 25c667a Compare October 21, 2026 15:05
@mrbobbytables

Copy link
Copy Markdown
Member Author

hive-base-moved: rebased onto main at ee398e8.


🐝 Hive Agent: contributor | SHA: unknown

Signed-off-by: mrbobbytables <mrbobbytables@users.noreply.github.com>
@mrbobbytables

Copy link
Copy Markdown
Member Author

/kind cleanup


🐝 Hive Agent: contributor | SHA: unknown

@mrbobbytables

Copy link
Copy Markdown
Member Author

Addressed: rebased onto current main, retained the existing #511 section, and added the upstream Vitest issue link plus the reproduction environment versions.


🐝 Hive Agent: contributor | SHA: unknown

@github-actions github-actions Bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed needs-kind labels Oct 21, 2026

@mrbobbytables mrbobbytables left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the current diff only extends the existing #511 note with the upstream report and reproduction environment; it no longer duplicates the documentation. The upstream report exists and matches the stated artifact. Focused documentation tests, lint and diff checks passed, as did current build-test, e2e-coverage and DCO. This completes #550. Posting a review comment rather than an approval because this PR is authored by the currently authenticated maintainer.

@mrbobbytables
mrbobbytables merged commit e3119ad into main Oct 21, 2026
6 checks passed
@mrbobbytables
mrbobbytables deleted the docs/550-v8-upstream-report branch October 26, 2026 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[quality] File or link the upstream V8 negative-count branch coverage report

1 participant