Skip to content

test(errorPaths): pin the GitHub refusal in every wrapped issue-comment failure #547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrbobbytables merged 1 commit into from
Oct 21, 2026
Merged

test(errorPaths): pin the GitHub refusal in every wrapped issue-comment failure #547

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 13 additions & 11 deletions __tests__/issueCommentTest/errorPaths.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ afterAll(() => server.close())
const issue = `${utils.api}/repos/Codertocat/Hello-World/issues/1`
const pull = `${utils.api}/repos/Codertocat/Hello-World/pulls/1`
const forbidden = { message: 'Resource not accessible by integration' }
// every wrap interpolates the rejection (`${e}`), so the failure names the GitHub refusal, not just the step
const cause = 'HttpError: Resource not accessible by integration'
const author = issueCommentEvent.issue.user.login

function comment(body: string, commenter = author) {
Expand Down Expand Up @@ -63,14 +65,14 @@ describe('/assign error paths', () => {
vi.mocked(auth.checkCommenterAuth).mockResolvedValueOnce(true)
failing('post', `${issue}/assignees`)

await expect(assign(comment('/assign'))).rejects.toThrow(/could not self assign/)
await expect(assign(comment('/assign'))).rejects.toThrow(`could not self assign: ${cause}`)
})

it('wraps a failed assignment of authorized users', async () => {
vi.mocked(auth.getOrgCollabCommentUsers).mockResolvedValueOnce(['some-user'])
failing('post', `${issue}/assignees`)

await expect(assign(comment('/assign @some-user'))).rejects.toThrow(/could not add assignees/)
await expect(assign(comment('/assign @some-user'))).rejects.toThrow(`could not add assignees: ${cause}`)
})
})

Expand All @@ -84,15 +86,15 @@ describe('/unassign error paths', () => {
it('wraps a failed self unassignment', async () => {
failing('delete', `${issue}/assignees`)

await expect(unassign(comment('/unassign'))).rejects.toThrow(/could not remove assignee/)
await expect(unassign(comment('/unassign'))).rejects.toThrow(`could not remove assignee: ${cause}`)
})

it('wraps a failed unassignment of another user', async () => {
vi.mocked(auth.checkCommenterAuth).mockResolvedValueOnce(true)
failing('delete', `${issue}/assignees`)

await expect(unassign(comment('/unassign @some-user'))).rejects.toThrow(
/could not remove assignee/,
`could not remove assignee: ${cause}`,
)
})
})
Expand All @@ -106,14 +108,14 @@ describe('/cc error paths', () => {
vi.mocked(auth.checkCollaborator).mockResolvedValueOnce(true)
failing('post', `${pull}/requested_reviewers`)

await expect(cc(comment('/cc'))).rejects.toThrow(/could not self cc/)
await expect(cc(comment('/cc'))).rejects.toThrow(`could not self cc: ${cause}`)
})

it('wraps a failed review request for authorized users', async () => {
vi.mocked(auth.getOrgCollabCommentUsers).mockResolvedValueOnce(['some-user'])
failing('post', `${pull}/requested_reviewers`)

await expect(cc(comment('/cc @some-user'))).rejects.toThrow(/could not request reviewers/)
await expect(cc(comment('/cc @some-user'))).rejects.toThrow(`could not request reviewers: ${cause}`)
})
})

Expand All @@ -126,7 +128,7 @@ describe('/uncc error paths', () => {
vi.mocked(auth.checkCollaborator).mockResolvedValueOnce(true)
failing('delete', `${pull}/requested_reviewers`)

await expect(uncc(comment('/uncc'))).rejects.toThrow(/could not self uncc/)
await expect(uncc(comment('/uncc'))).rejects.toThrow(`could not self uncc: ${cause}`)
})
})

Expand All @@ -140,7 +142,7 @@ describe('/reopen error paths', () => {
it('wraps a failed reopen', async () => {
failing('patch', issue)

await expect(reopen(comment('/reopen'))).rejects.toThrow(/could not open issue/)
await expect(reopen(comment('/reopen'))).rejects.toThrow(`could not open issue: ${cause}`)
})
})

Expand All @@ -154,7 +156,7 @@ describe('/close error paths', () => {
it('wraps a failed close', async () => {
failing('patch', issue)

await expect(close(comment('/close'))).rejects.toThrow(/could not close issue/)
await expect(close(comment('/close'))).rejects.toThrow(`could not close issue: ${cause}`)
})
})

Expand All @@ -170,7 +172,7 @@ describe('/retitle error paths', () => {
failing('patch', issue)

await expect(retitle(comment('/retitle new title'))).rejects.toThrow(
/could not update issue/,
`could not update issue: ${cause}`,
)
})
})
Expand All @@ -184,6 +186,6 @@ describe('/lock error paths', () => {
vi.mocked(auth.checkCollaborator).mockResolvedValueOnce(true)
failing('put', `${issue}/lock`)

await expect(lock(comment('/lock'))).rejects.toThrow(/could not lock issue/)
await expect(lock(comment('/lock'))).rejects.toThrow(`could not lock issue: ${cause}`)
})
})
Loading