Repository navigation
test(errorPaths): pin the GitHub refusal in every wrapped issue-comment failure - #547
Conversation
…nt failure Each 'could not …' wrap in src/issueComment/* interpolates the rejection, so the Action failure names the HttpError GitHub returned. The eleven error-path tests matched the prefix only; dropping the cause from any wrap left them green. Each now asserts the full 'could not <step>: HttpError: Resource not accessible by integration' message. Signed-off-by: quality <280983584+hivecommons-hive[bot]@users.noreply.github.com>
|
Important Held for human review by the hive's ACMM level gate. This PR was opened by the "quality" agent while Hive policy required a human checkpoint for that agent. Agent PRs are held at ACMM L3–L5; an Hive will keep the |
|
Please add a kind label with |
mrbobbytables
left a comment
There was a problem hiding this comment.
Copilot review performed under the maintainer's explicit authorization to update, review, release reviewed holds, and merge eligible PRs in this cleanup.
The existing wrapped-failure assertions now retain the underlying GitHub refusal instead of matching only a generic prefix; changes remain test-only.
Verified successful build-test, e2e-coverage and DCO results on head 8511d84. Any folded issue findings remain assigned to the canonical destinations in the updated scope tables.
Test Improvement
__tests__/issueCommentTest/errorPaths.test.tsasserted the elevencould not …wraps insrc/issueComment/*(assign.ts:42,73,unassign.ts:42,64,cc.ts:39,70,uncc.ts:38,reopen.ts:45,close.ts:60,retitle.ts:51,lock.ts:62) by prefix only, so dropping the interpolated rejection (: ${e}) from any of them left the suite green — verified onmain@ 88241f4 forclose.ts:60andreopen.ts:45(npx vitest related …→ 576/576 pass) andlock.ts:62(the file directly, 19/19). That cause (HttpError: Resource not accessible by integration) is the only line a maintainer gets when a token lacks a permission.Each of the eleven assertions now matches the full message,
could not <step>: HttpError: Resource not accessible by integration, via one sharedcauseconstant.Files:
__tests__/issueCommentTest/errorPaths.test.tsonly. Nosrc/,dist/or docs change. Disjoint from every open held PR (#510–#545): none touches this file.Verification (this branch, local)
npx vitest run __tests__/issueCommentTest/errorPaths.test.ts: 19/19 passnpx eslint __tests__/issueCommentTest/errorPaths.test.ts: cleanclose.ts:60could not close issue: ${e}→could not close issue: the file now fails 1/19 (Received: "could not close issue")Related Issue
Refs #523 — the folded errorPaths finding on that tracker is fully addressed by this PR; the tracker stays open for its other folded findings (e2e
String(e)arms,run.ts:40/config.ts:657/lgtm.ts:68v8-ignore text, which need asrc/change — needs-human: production-file edits outside the quality lane).Filed by quality agent (hold-gated mode). Human review required.
— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88