Repository navigation
test(sweep): pin blunderbuss ignore_authors on the sweep and the since-window edge - #516
Conversation
…e-window edge Four single-operator mutants in src/cronJobs/sweep.ts survived the full vitest related set: explicit:false -> true at line 163 (the sweep would request reviewers on pull requests by blunderbuss.ignore_authors), and the three comparisons against since at lines 149, 178 and 179 (a pull request updated or opened exactly at the start of the window, and a full page whose oldest entry sits on it). Each now fails at least one of the four added cases; no src/ change. Signed-off-by: quality <280983584+hivecommons-hive[bot]@users.noreply.github.com>
|
Important Held for human review by the hive's ACMM level gate. This PR was opened by the "quality" agent while Hive policy required a human checkpoint for that agent. Agent PRs are held at ACMM L3–L5; an Hive will keep the |
|
Please add a kind label with |
mrbobbytables
left a comment
There was a problem hiding this comment.
Copilot review performed under the maintainer's explicit authorization to update, review, release reviewed holds, and merge eligible PRs in this cleanup.
The sweep cases observe inclusive time boundaries, continuation beyond a full page ending at the boundary, and the case-insensitive ignored-author no-write behavior.
Verified successful build-test, e2e-coverage and DCO results on head 71a1ab1. Any folded issue findings remain assigned to the canonical destinations in the updated scope tables.
Test Improvement
Files:
__tests__/cronJobTest/sweep.test.tsonly. Nosrc/,dist/,docs/oreslint.config.mjschange — disjoint from #510 (src/utils/auth.ts,dist/index.js), #511 (docs/contributing.md), #512 (__tests__/label/remove.test.ts,eslint.config.mjs) and #514 (__tests__/utils/labelMatch.test.ts,__tests__/utils/command.test.ts).A single-operator mutation probe over
src/cronJobs/*andsrc/plugins/{ownersLabel,blunderbuss,requireMatchingLabel,lgtmBinding}.tsonmain@ 88241f4 (258 mutants; details on #515) left four non-equivalent survivors against their fullvitest relatedset, all insrc/cronJobs/sweep.ts. Four cases pin them:sweep candidates› includes a pull request updated exactly at the start of the window —sweep.ts:178(>=onupdated_at).sweep candidates› a full page whose oldest entry sits exactly on the start of the window is not the last page —sweep.ts:179(theexhaustedfold); assertspage=1andpage=2were listed viaservePulls'slistCalls.sweep on a repository with OWNERS files› a pull request opened exactly at the start of the window is fresh and gets reviewers —sweep.ts:149(<oncreated_at).sweep on a repository with OWNERS files› a fresh pull request by an author inblunderbuss.ignore_authorsgets no reviewers —sweep.ts:163(explicit: false); configuresignore_authors: [Dave]throughprowYaml, asserts therequested_reviewersPOST is not made andcore.debuglogsblunderbuss: ignoring pull request by dave(also pins the case-insensitive match).Verification (this branch, local)
npx vitest run __tests__/cronJobTest/sweep.test.ts: 35 passed (31 onmain)src/cronJobs/sweep.tsin turn::1491 failed,:1631 failed,:1783 failed,:1791 failed (mutants reverted, not committed)npx eslint __tests__/cronJobTest/sweep.test.ts: cleanPOST /graphql,GET /branches/master) is the patternmainalready prints for the existing 100-pull-request paging test; the 100-pull-request case here adds the same.Related Issue
Fixes #515
Filed by quality agent (hold-gated mode). Human review required.
— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88