[umeraamir69]

Fixes #10285

Sign-in and sign-up identifier fields were rendered without autocomplete, except a bare webauthn when passkey autofill was on. Browsers and the iOS keyboard then had nothing to treat the field as email/name/phone.

This sets the HTML autocomplete tokens:

• Sign-in identifier: email, tel, or username (mixed identifiers use username). With passkey autofill, webauthn is appended (email webauthn).
• Sign-up: email, tel, username, given-name, family-name.

Test plan

• Sign-in: email-only, phone-only, mixed email+username
• Sign-in: passkey autofill uses email webauthn
• Sign-up: name, email, phone, username tokens

[vercel]

@umeraamir69 is attempting to deploy a commit to the Clerk Production Team on Vercel.

A member of the Team first needs to authorize it.

[changeset-bot]

🦋 Changeset detected

Latest commit: e5eedde

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@clerk/ui	Patch
@clerk/chrome-extension	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Source mode: Auto
• Repository: clerk/javascript
• Branch: main
• File: .coderabbit.yaml
• Commit: 141916c
• Layers: Repository YAML (base), Organization UI (inherited)
• Review profile: ASSERTIVE
• Plan: Advanced
• Run ID: 810b3569-748e-4135-b9c8-3c55a133ba68

📥 Commits

Reviewing files that changed from the base of the PR and between 141916c and e5eedde.

📒 Files selected for processing: 5

• .changeset/signin-signup-autocomplete.md
• packages/ui/src/components/SignIn/SignInStart.tsx
• packages/ui/src/components/SignIn/__tests__/SignInStart.test.tsx
• packages/ui/src/components/SignUp/SignUpForm.tsx
• packages/ui/src/components/SignUp/__tests__/SignUpStart.test.tsx

🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

• clerk/clerk_go (manual)
• clerk/dashboard (manual)
• clerk/accounts (manual)
• clerk/backoffice (manual)
• clerk/clerk (manual)
• clerk/clerk-docs (manual)
• clerk/cloudflare-workers (manual)

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 0 remain after this review.

📝 Walkthrough

Sign-in identifier fields now use email, tel, or username autocomplete tokens. When WebAuthn autofill is supported, webauthn is appended. Sign-up name, username, email, and phone fields now use their corresponding standard autocomplete tokens. Tests cover the rendered autocomplete values.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Severity of issue fixed: Medium

Suggested reviewers: alexcarpenter

Merge Risk: ⚪ Minimal · up to e5eed

The autocomplete changes are covered by the supplied implementation and rendered-attribute tests.

Pre-merge checks: 4 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Docstring Coverage		Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 4 files. (1 skipped: 1 …	Write docstrings for the functions missing them to satisfy the coverage threshold.

Passed checks: 4 passed

Check name	Status	Explanation
Title check		The title clearly and concisely summarizes the main change to SignIn and SignUp identifier fields.
Description check		The description directly explains the autocomplete changes, affected fields, passkey behavior, and test coverage.
Linked Issues check		Issue #10285 requires standard autocomplete tokens on SignIn and SignUp identifier fields. The reviewed SignIn diff maps phone_number to tel, email_address to email, and other identifiers to `…
Out of Scope Changes check		The changes stay within issue #10285. The implementation adds autocomplete values to the SignIn and SignUp fields. The tests verify those values. The changeset documents the same behavior. No unrelate…

Full details: Linked Issues check

Explanation

Issue #10285 requires standard autocomplete tokens on SignIn and SignUp identifier fields. The reviewed SignIn diff maps phone_number to tel, email_address to email, and other identifiers to username. It appends webauthn after the token when passkey autofill is supported. The supplied change summary reports the required SignUp tokens: email, tel, username, given-name, and family-name. Added tests cover the SignIn identifier cases, passkey autofill, and the SignUp fields.

Full details: Out of Scope Changes check

Explanation

The changes stay within issue #10285. The implementation adds autocomplete values to the SignIn and SignUp fields. The tests verify those values. The changeset documents the same behavior. No unrelated change is shown in the reviewed scope.

Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 4 files. (1 skipped: 1 unsupported.)

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

✨ Finishing Touches: 💡 1

🛠️ Fix failing CI checks: 💡

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Linked repositories: Some configured repositories could not be included in this review. Cross-repository analysis may be incomplete. Please check linked-repository access and settings.

_{Comment @coderabbitai help to get the list of available commands.}

[alexcarpenter]

Thanks for this, @umeraamir69! CI doesn't run on PRs from forks, so we've moved your change to #10365. Your commit is kept there with you as the author, plus a small follow-up that moves the autocomplete token into FirstFactorConfigs.

[umeraamir69]

Thanks for moving this, Alex. Fork PRs don't get CI here, so pulling it into #10365 is the only way it actually runs.

I saw you kept my commit as the author and then parked the autocomplete token on FirstFactorConfigs, next to type/label/placeholder. That's cleaner than leaving it as a one-off on the field.

I'll watch #10365 from here.