Skip to content

fix: source release-config.sh from main in build-docker.yaml #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ZhiyuCircle merged 1 commit into from
Jul 22, 2026
+17 −4
Merged

fix: source release-config.sh from main in build-docker.yaml #216

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 17 additions & 4 deletions .github/workflows/build-docker.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ jobs:
with:
ref: ${{ (github.event_name == 'workflow_call' || github.event_name == 'workflow_dispatch') && format('refs/tags/{0}', inputs.tag) || github.ref }}
submodules: recursive
fetch-depth: 0

- name: Resolve image metadata
id: vars
Expand All @@ -69,8 +70,12 @@ jobs:
run: |
SHA="$(git rev-parse HEAD)"
if [[ "$EVENT_NAME" == "workflow_call" || "$EVENT_NAME" == "workflow_dispatch" ]]; then
# shellcheck source=scripts/release-config.sh
source scripts/release-config.sh
# A release branch's release-config.sh can predate functions this workflow
# (always run from main) expects, so pull main's copy rather than whatever
# is checked out at the tagged commit above.
git show origin/main:scripts/release-config.sh > "${RUNNER_TEMP}/release-config.sh"
# shellcheck source=/dev/null
source "${RUNNER_TEMP}/release-config.sh"
if ! release_docker_image_version_from_tag "$INPUT_TAG" >/dev/null; then
echo "::error::Invalid tag format: '$INPUT_TAG' (expected e.g. v1.2.3 or v1.2.3-rc.1)"
exit 1
Expand Down Expand Up @@ -180,6 +185,7 @@ jobs:
sparse-checkout: |
.github/actions
scripts
fetch-depth: 0

- name: Set up Docker Buildx
uses: docker/setup-buildx-action@d7f5e7f509e45cec5c76c4d5afdd7de93d0b3df5 # v4.1.0
Expand All @@ -202,12 +208,19 @@ jobs:
IMAGE: ${{ env.REGISTRY }}/${{ env.REGISTRY_NAMESPACE }}/${{ matrix.image }}
RELEASE_TAG: ${{ inputs.tag }}
run: |
# shellcheck source=scripts/release-config.sh
source scripts/release-config.sh
# A release branch's release-config.sh can predate functions this workflow
# (always run from main) expects, so pull main's copy rather than whatever
# is checked out at the tagged commit above.
git show origin/main:scripts/release-config.sh > "${RUNNER_TEMP}/release-config.sh"
# shellcheck source=/dev/null
source "${RUNNER_TEMP}/release-config.sh"
if ! IMAGE_VERSION="$(release_docker_image_version_from_tag "$RELEASE_TAG")"; then
echo "::error::Invalid tag format: '$RELEASE_TAG' (expected e.g. v1.2.3 or v1.2.3-rc.1)"
exit 1
fi
# Defense in depth: never publish a vX.Y.Z-tagged image, even if the
# sourced parser regresses and stops stripping the leading "v".
IMAGE_VERSION="${IMAGE_VERSION#v}"
SHA="$(git rev-parse HEAD)"
SHORT_HASH="${SHA::8}"
TAG="${IMAGE}:${IMAGE_VERSION}"
Expand Down