fix: source release-config.sh from main in build-docker.yaml#216
Merged
ZhiyuCircle merged 1 commit intoJul 22, 2026
Merged
Conversation
A release tag can point at an old commit whose release-config.sh predates fixes this workflow expects, so the checked-out copy silently computes a wrong image version. v0.7.3 published Docker tags as "v0.7.3" instead of "0.7.3" because of exactly this: pull the script from origin/main instead, and strip a stray leading "v" as a backstop. Co-authored-by: Cursor <cursoragent@cursor.com>
sdaveas-circle
force-pushed
the
fix/public-docker-tag-v-prefix
branch
from
July 22, 2026 17:25
31a1cad to
02f4c10
Compare
ZhiyuCircle
approved these changes
Jul 22, 2026
github-actions
Bot
added
the
pending-import
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
v0.7.3's public Docker images were taggedv0.7.3instead of0.7.3, inconsistent with every prior release.Details
Both the
buildandmanifestjobs check outrefs/tags/{tag}and thensource scripts/release-config.shfrom that same checked-out tree. Thev0.7.3tag pointed at an older commit whose copy ofrelease-config.shpredated the fix that strips the leadingvfrom the parsed version — sorelease_docker_image_version_from_tagreturnedv0.7.3verbatim, and themanifestjob tagged the image with it directly (docker buildx imagetools create -t "${IMAGE}:${IMAGE_VERSION}").Fix:
scripts/release-config.shfromorigin/maininstead of the tag checkout (needsfetch-depth: 0to makeorigin/mainresolvable), so the parser used is always current regardless of which commit the tag happens to point at.vfromIMAGE_VERSIONright before building the tag, so a future parser regression can't silently republish avX.Y.Ztag.Testing
ruby -e "require 'yaml'; YAML.load_file('.github/workflows/build-docker.yaml')"— cleanactionlint .github/workflows/build-docker.yaml— cleanrelease-config.sh(raw tag passthrough) checked out at a tag producesv0.7.3; sourcing the currentmaincopy instead produces0.7.3.Documentation
N/A — CI workflow-only change.