Skip to content

Change parameter order for docker-no-tty. #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marwaneltoukhy merged 1 commit into from
May 12, 2026
Merged

Change parameter order for docker-no-tty. #25

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions chipfoundry_cli/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4094,7 +4094,6 @@ def get_valid_from_steps(librelane_python, macro_config, working_dir):
str(venv_bin / 'python3'), '-m', 'librelane',
'-m', str(project_root_path),
'-m', str(pdk_root),
'--dockerized',
]

# Add --docker-no-tty if not running in a TTY (e.g., CI environments)
Expand All @@ -4104,7 +4103,10 @@ def get_valid_from_steps(librelane_python, macro_config, working_dir):
except:
# If we can't detect TTY, assume non-TTY (safer for CI)
cmd.append('--docker-no-tty')


# --docker-no-tty must come before --dockerized
cmd.append('--dockerized')

cmd.extend([
'--manual-pdk',
'--pdk-root', str(pdk_root),
Expand Down Expand Up @@ -5392,4 +5394,4 @@ def whoami_cmd():


if __name__ == "__main__":
main()
main()
Loading