Skip to content

Kind image updater changes #618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cert-manager-prow merged 3 commits into from
May 20, 2026
Merged

Kind image updater changes #618

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8e3b2cf
security: require human review on updated kind images
SgtCoDFish May 20, 2026
1327bed
security: tighten regexes for kind SHAs
SgtCoDFish May 20, 2026
9c932d0
allow other endings to lines than just the carriage return
SgtCoDFish May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/kind-images-upgrade.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ jobs:
run: |
git config --global user.name "cert-manager-bot"
git config --global user.email "cert-manager-bot@users.noreply.github.com"
git add -A && git commit -m "BOT: run 'make upgrade-klone' and 'make generate'" --signoff
git add -A && git commit -m "BOT: run 'make upgrade-kind-images'" --signoff
git push -f origin "$SELF_UPGRADE_BRANCH"

- if: ${{ steps.is-up-to-date.outputs.result != 'true' }}
Expand Down Expand Up @@ -92,6 +92,5 @@ jobs:
owner,
repo,
issue_number: result.data.number,
labels: ['skip-review']
});
}
5 changes: 4 additions & 1 deletion scripts/learn_kind_images.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,8 +96,11 @@ echo "kind_image_kindversion := ${kind_version}" >> "${kind_versionfile}.tmp"

echo "" >> "${kind_versionfile}.tmp"

# Example literal line from kind release notes that we're trying to match in the capture below:
# - v1.34.3: `kindest/node:v1.34.3@sha256:08497ee19eace7b4b5348db5c6a1591d7752b164530a36f855cb0f2bdcbadd48`\r\n

release_json=$(curl -fsSL "https://api.github.com/repos/kubernetes-sigs/kind/releases/tags/${kind_version}"| jq '
[ .body | capture("- v?1\\.(?<minor>[0-9]+)(.(?<patch>[0-9]+))?: `kindest/node:v(?<version>[^@]+)@sha256:(?<sha256>[^`]+)`\r"; "g") ]
[ .body | capture("- v?1\\.(?<minor>[0-9]+)(\\.(?<patch>[0-9]+))?: `kindest/node:v(?<version>[0-9]+\\.[0-9]+\\.[0-9]+(-[A-Za-z0-9.]+)?)@sha256:(?<sha256>[A-Fa-f0-9]{64})`(\\r?\\n|$)"; "g") ]
| group_by(.minor) | map(max_by(.patch))
| sort_by(.minor)'
)
Expand Down
Loading