Kind image updater changes#618
Conversation
SgtCoDFish
commented
May 20, 2026
- Fix commit description of kind-images-upgrade job
- Remove skip-review from kind-images-upgrade PR, since the source of the kind images is a free-input release note that could contain anything. Someone should review to be sure.
- Tighten regex rules so that we only accept things that look like version numbers and SHA256SUMs (AI-generated regexes)
Signed-off-by: Ashley Davis <ashley.davis@cyberark.com>
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the kind image upgrade automation to improve traceability, require human review, and harden release-note parsing against unexpected input.
Changes:
- Tighten the release-note parsing regex in
learn_kind_images.shto only accept semver-like versions and 64-hex SHA256 digests - Update the bot commit message to reflect the correct upgrade command
- Remove the
skip-reviewlabel from the automated kind-images-upgrade PRs
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| scripts/learn_kind_images.sh | Narrows the jq capture() regex for kind release-note parsing |
| .github/workflows/kind-images-upgrade.yaml | Adjusts bot commit message and removes skip-review label application |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Ashley Davis <ashley.davis@cyberark.com>
Signed-off-by: Ashley Davis <ashley.davis@cyberark.com>
aec24f4 to
9c932d0
Compare
erikgb
left a comment
There was a problem hiding this comment.
I am not an expert on regexes, but the rest of the PR looks good. And AI is probably not completely off. Thanks! 🚀
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: erikgb The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |