Skip to content

Kind image updater changes#618

Merged
cert-manager-prow[bot] merged 3 commits into
cert-manager:mainfrom
SgtCoDFish:kind-images-need-review
May 20, 2026
Merged

Kind image updater changes#618
cert-manager-prow[bot] merged 3 commits into
cert-manager:mainfrom
SgtCoDFish:kind-images-need-review

Conversation

@SgtCoDFish
Copy link
Copy Markdown
Member

  1. Fix commit description of kind-images-upgrade job
  2. Remove skip-review from kind-images-upgrade PR, since the source of the kind images is a free-input release note that could contain anything. Someone should review to be sure.
  3. Tighten regex rules so that we only accept things that look like version numbers and SHA256SUMs (AI-generated regexes)

Signed-off-by: Ashley Davis <ashley.davis@cyberark.com>
@cert-manager-prow cert-manager-prow Bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 20, 2026
@erikgb erikgb requested a review from Copilot May 20, 2026 16:07
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Updates the kind image upgrade automation to improve traceability, require human review, and harden release-note parsing against unexpected input.

Changes:

  • Tighten the release-note parsing regex in learn_kind_images.sh to only accept semver-like versions and 64-hex SHA256 digests
  • Update the bot commit message to reflect the correct upgrade command
  • Remove the skip-review label from the automated kind-images-upgrade PRs

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
scripts/learn_kind_images.sh Narrows the jq capture() regex for kind release-note parsing
.github/workflows/kind-images-upgrade.yaml Adjusts bot commit message and removes skip-review label application

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread scripts/learn_kind_images.sh Outdated
Comment thread scripts/learn_kind_images.sh Outdated
Signed-off-by: Ashley Davis <ashley.davis@cyberark.com>
Signed-off-by: Ashley Davis <ashley.davis@cyberark.com>
@SgtCoDFish SgtCoDFish force-pushed the kind-images-need-review branch from aec24f4 to 9c932d0 Compare May 20, 2026 16:54
Copy link
Copy Markdown
Member

@erikgb erikgb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not an expert on regexes, but the rest of the PR looks good. And AI is probably not completely off. Thanks! 🚀

/lgtm
/approve

@cert-manager-prow cert-manager-prow Bot added the lgtm Indicates that a PR is ready to be merged. label May 20, 2026
@cert-manager-prow
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: erikgb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 20, 2026
@cert-manager-prow cert-manager-prow Bot merged commit 2a13bcc into cert-manager:main May 20, 2026
5 checks passed
@SgtCoDFish SgtCoDFish deleted the kind-images-need-review branch May 20, 2026 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants