Repository navigation
Render tab: Select finished ticks every take whose clips are done, to clear leftover takes in one go (part of #644) - #997
Conversation
… this clock Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Review (unattended pass): merged Matches #716: each row's Fixed (c6ed84d): with "of any age", a take whose last start time is ahead of this PC's clock (rendered on another PC with a fast clock, or before the clock was set back) failed Not changed: the exact-boundary case ( Tests: Verdict: ready to merge. |
Release note: New: the Render tab's "Select finished" button ticks every take whose clips are done (optionally only those over a day, week or month old), so Delete Take folders clears leftover takes in one go.
Part of #644. Asked for on #716: "a way to select all finished takes on the render tab to clean up leftover renders".
What changes
Next to Select unrendered above the job table:
What "finished" means
The same rule as #716's automatic cleanup (
take_cleanup::finished_at):output_existsin the row's history).The rule lives in
studio/src/render_selection.js(takeFinishedAt,finishedTakeFolders), working from the rows' history, which the backend already sends. No Rust changes.Decisions
finished_atis in Rust and reads the take folder's streams from disk. This button only ticks rows, and Delete Take still asks before anything goes, so it uses the rows already in the list rather than adding a backend call. The difference: a take whose HUD row the user removed from the list counts as finished here (its remaining row is), while Delete finished takes automatically: Recycle Bin or permanent, optionally only when space is needed (part of #644) #716 would keep it. The two rules are otherwise identical. If they should be one, Delete finished takes automatically: Recycle Bin or permanent, optionally only when space is needed (part of #644) #716 could send afinished_atper take with the job snapshot and this button would read it; I didn't edit Delete finished takes automatically: Recycle Bin or permanent, optionally only when space is needed (part of #644) #716.Test done
npm run test:unit: 849 passed, including 4 new tests inrender_selection.test.js(last attempt wins, file gone, Queued/Rendering, HUD pair, age filter, Select finished feeding Delete Take's targets).CI=1 npx playwright test tests/e2e/render-studio.spec.js: 56 passed, including a new test: Select finished ticks the two finished takes, Delete Take folders shows (2); "over a day old" leaves only the old one, (1).To check by hand (Studio only)
🤖 Generated with Claude Code