Skip to content

Review: the empty Add a team list says No teams in full, not cut off (#845) - #1027

Merged
ccoventry merged 1 commit into
devfrom
fix/review-row-wrap-845
Oct 25, 2026
Merged

ccoventry merged 1 commit into
devfrom
fix/review-row-wrap-845

Conversation

@ccoventry

Copy link
Copy Markdown
Owner

Release note: Fixed: with HLTV set to Players I pick and no HLTV demos in the queue, the Add a team list says "No teams" in full instead of a cut-off sentence.

Closes #845

Where #845 stood

The layout itself was fixed by #862 (merged into dev on 10-19): the picked players' chips have a line of their own at the end of the Master Demo Queue toolbar, and Add a player… / Add a team… stay together with fixed widths. #862 said Closes #845 only in its body, so the issue never closed. Checked again tonight in the real app shell (index.html + main.js booted under the e2e harness, HLTV set to Players I pick) at 1920, 1280, 1000 and 800 px wide, with no chips and with five: at every width the two lists sit side by side and the chips wrap on their own line(s) underneath.

What was left: the 160 px team list cut its empty-queue text, "No teams in the HLTV dem…", at every width (also in #862's live screenshots).

What changes

  • REVIEW.PICK_NO_TEAMS is now No teams. The list's tooltip already says where teams come from, and the player list beside it says "No HLTV highlights in the queue".
  • review-hltv.spec.js: the empty-queue test checks both lists' text fits their fixed widths beside the arrow (canvas-measured), and that the team list says "No teams". The harness's two lists get index.html's padding and font size so that measure means something.

Decisions

Screenshots

local\review-images\845\ in the main checkout: before-<width>-<empty|chips>.png (dev) and after-… (this branch), widths 1920, 1280, 1000, 800. The chips in the chips shots are drawn the way the picker draws them.

Test done

  • npx playwright test review-hltv.spec.js app-boot.spec.js (CI=1): 11 of 11 pass. The changed test fails on dev's string. The fit check's numbers here: the player line is 172 px in 174 px of room; dev's team line would be about 145 px in 134.
  • npm run test:unit: 854 of 854 pass.
  • No Rust changed; cargo test, clippy and fmt (1.98.1) passed on the same dev base in Duplicates scan reads a hard disk one file at a time (#941) #1024.

For the user to test

  1. Studio from this branch, Master Demo Queue with no HLTV demos in it: set HLTV to Players I pick. The team list reads No teams, not cut off.
  2. Add an HLTV demo and pick two or three players: the chips sit on their own line under the toolbar and Add a player… / Add a team… stay side by side. Narrow and widen the window.

Other open PRs on the same files

studio/src/strings.js is also changed by #425, #716, #760, #832, #874, #879, #881, #885, #996, #997, #1001, #1007 and #1025; none of them touch the HLTV pick strings, so no conflict expected. No open PR touches review-hltv.spec.js or review-hltv.html.

🤖 Generated with Claude Code

The 160 px list cut "No teams in the HLTV demos" short at every width.
The rest of #845 (lists together, chips on their own line) shipped in
#862; the e2e test now also checks both lists' empty text fits.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@ccoventry ccoventry linked an issue Oct 25, 2026 that may be closed by this pull request
@ccoventry
ccoventry merged commit 5bcbad9 into dev Oct 25, 2026
6 checks passed
@ccoventry
ccoventry deleted the fix/review-row-wrap-845 branch October 25, 2026 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Review row layout: HLTV pick controls wrap onto extra lines

1 participant