Repository navigation
Review: the empty Add a team list says No teams in full, not cut off (#845) - #1027
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release note: Fixed: with HLTV set to Players I pick and no HLTV demos in the queue, the Add a team list says "No teams" in full instead of a cut-off sentence.
Closes #845
Where #845 stood
The layout itself was fixed by #862 (merged into dev on 10-19): the picked players' chips have a line of their own at the end of the Master Demo Queue toolbar, and Add a player… / Add a team… stay together with fixed widths. #862 said
Closes #845only in its body, so the issue never closed. Checked again tonight in the real app shell (index.html+main.jsbooted under the e2e harness, HLTV set to Players I pick) at 1920, 1280, 1000 and 800 px wide, with no chips and with five: at every width the two lists sit side by side and the chips wrap on their own line(s) underneath.What was left: the 160 px team list cut its empty-queue text, "No teams in the HLTV dem…", at every width (also in #862's live screenshots).
What changes
REVIEW.PICK_NO_TEAMSis now No teams. The list's tooltip already says where teams come from, and the player list beside it says "No HLTV highlights in the queue".review-hltv.spec.js: the empty-queue test checks both lists' text fits their fixed widths beside the arrow (canvas-measured), and that the team list says "No teams". The harness's two lists get index.html's padding and font size so that measure means something.Decisions
Screenshots
local\review-images\845\in the main checkout:before-<width>-<empty|chips>.png(dev) andafter-…(this branch), widths 1920, 1280, 1000, 800. The chips in thechipsshots are drawn the way the picker draws them.Test done
npx playwright test review-hltv.spec.js app-boot.spec.js(CI=1): 11 of 11 pass. The changed test fails on dev's string. The fit check's numbers here: the player line is 172 px in 174 px of room; dev's team line would be about 145 px in 134.npm run test:unit: 854 of 854 pass.cargo test, clippy and fmt (1.98.1) passed on the same dev base in Duplicates scan reads a hard disk one file at a time (#941) #1024.For the user to test
Other open PRs on the same files
studio/src/strings.jsis also changed by #425, #716, #760, #832, #874, #879, #881, #885, #996, #997, #1001, #1007 and #1025; none of them touch the HLTV pick strings, so no conflict expected. No open PR touchesreview-hltv.spec.jsorreview-hltv.html.🤖 Generated with Claude Code