Repository navigation
An installed DoD Studio loads its own hook DLL into the game again - #916
Merged
Merged
Conversation
Tauri v2 puts bundle resources beside the exe, not under resources\, so installed builds never found the DLL; with the override ignored in releases (#912) the game launched without the hook. Look beside the exe first, then resources\ for older installs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release note: Fixed: an installed DoD Studio loads its own hook DLL into the game again.
Found testing 0.2.0-8: Launch Game started the game through HLAE but without DoD Studio's hook DLL (no in-game window, no
ds_*commands, no hook log). This stopped the v0.2.0 release: its stable run was cancelled before publishing, so no v0.2.0 release or tag exists.Cause.
native::patch::default_goldsrc_hooks_dll_pathlooked for the bundled DLL at<install>\resources\goldsrc-hooks\dodstudio_goldsrc_hooks.dll. Tauri v2's NSIS installer putsbundle.resourcesbeside the exe instead (Tauri'sresource_dir, whichhd-scriptsandlocalizationsalready use): the user's install has it at<install>\goldsrc-hooks\dodstudio_goldsrc_hooks.dll. So an installed build never found its bundled DLL. That went unnoticed while the GoldSrc Hooks DLL override was set; #912 made installed releases ignore the override, so they injected nothing.Fix. The bundled DLL is looked for beside the exe first, then under
resources\(older installs;installer_hooks.nshstill cleans that spot up after the old DoD Tools Studio). With neither, the current spot is named, as before. A missing file still means "not injected".Tests
cargo test -p native bundled_hooks_dll: 3 new, pass (current layout, older layout, neither).-D warnings) clean for native; rustfmt clean.ds_debug_statusanswers, with no override set.🤖 Generated with Claude Code