Skip to content

Use default config.yaml instead of profiles to define .test as the working directory - #14

Merged
Sergio-ote merged 9 commits into
devfrom
fix/linting-test-dir
Sep 15, 2026
Merged

Sergio-ote merged 9 commits into
devfrom
fix/linting-test-dir

Conversation

@dgruano

@dgruano dgruano commented Sep 12, 2026 •

Copy link
Copy Markdown
Collaborator

What & why

In PR #7 we fixed the linting, but introduced another unexpected bug: since the working directory is defined in a profile at profiles/default/config.yaml, it will always get loaded as a local profile (--worflow-profile) on top of the global profile (--profile). This will force execution under the .test directory even if the user defines a global profile with a different directoryparameter, making it very conterintuitive and difficult to debug.

After discussing with @Sergio-ote , we decided to stop using profiles for this and use the default workflow config to define all parameters relative to .test. Since the user will always have to edit the default configuration to adapt the pipeline to their needs, this is not only the simplest but also the easiest for the user.

Validation

  • Workflow lint passes against .test/
  • Decoupled .test/ dry-run builds the CoreBlock DAG
  • Config validates against workflow/schemas/config.schema.yaml
  • mkdocs build --strict passes, if documentation was changed
  • Catalogue rule graph was generated before a release, if applicable

@Sergio-ote

Copy link
Copy Markdown
Collaborator

Hey @dgruano, thanks for the effort here.

I have cleaned the config files, stale code, documentation, and included an additional test for CI/CD to make sure we do not have this issue in the future. I have checked all the points in the CONTRIBUTING.md and everything passes.

I still have to fix a minor bug with differential expression (LRT running when there are less than 3 levels) and double check the docs, but we are almost ready for a new release. Great work, I really appreciate it!

@Sergio-ote
Sergio-ote marked this pull request as ready for review September 15, 2026 21:54
@Sergio-ote
Sergio-ote merged commit 7766cc2 into dev Sep 15, 2026
3 checks passed
@Sergio-ote
Sergio-ote deleted the fix/linting-test-dir branch September 15, 2026 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants