Work around GCC co_await bugs in test macros#3092
Open
vasama wants to merge 1 commit intocatchorg:develfrom
Open
Work around GCC co_await bugs in test macros#3092vasama wants to merge 1 commit intocatchorg:develfrom
vasama wants to merge 1 commit intocatchorg:develfrom
Conversation
Related GCC issues: * https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101027 * https://gcc.gnu.org/bugzilla/show_bug.cgi?id=116775 Related Catch2 issues: * catchorg#2591 * catchorg#2925
vasama
force-pushed
the
test-macro-gcc-co-await
branch
from
f2db3e0 to
5c8f9ec
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## devel #3092 +/- ##
==========================================
- Coverage 91.36% 91.33% -0.03%
==========================================
Files 204 204
Lines 8903 8903
==========================================
- Hits 8134 8131 -3
- Misses 769 772 +3 🚀 New features to boost your workflow:
|
Author
|
I had to add a variable initialiser in a test due to a now detected use of an uninitialised variable. Looks like the existing solution based on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related GCC issues:
Related Catch2 issues:
REQUIRE(co_await expr)unexpectedly repeats execution in GCC #2925Use a volatile boolean to guard the unevaluated test expression instead of
CATCH_INTERNAL_IGNORE_BUT_WARN(based on__builtin_constant_p, now removed).I did not remove
CATCH_CONFIG_USE_BUILTIN_CONSTANT_P, though it now seems to be unnecessary. It's unclear to me if removing it would break user configurations.