Skip to content

fix: deleted internal message data #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Akatuoro merged 5 commits into from
Oct 23, 2026
Merged

fix: deleted internal message data #213

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
13d5c29
fix: deleted internal message data
Akatuoro Oct 22, 2026
fdad96c
temporary fix for ci
Akatuoro Oct 23, 2026
706b78c
Merge branch 'main' into fix/shallow-checkpoint-copy
Akatuoro Oct 23, 2026
bc90652
Revert "temporary fix for ci"
Akatuoro Oct 23, 2026
d5c4ee9
Merge branch 'fix/shallow-checkpoint-copy' of https://github.com/cap-…
Akatuoro Oct 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions lib/protocol/persistence/checkpoint-saver.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,8 +158,12 @@ export class CdsCheckpointSaver extends BaseCheckpointSaver {
}

const prepared = copyCheckpoint(checkpoint)
for (const msg of prepared.channel_values.messages ?? []) {
delete msg.additional_kwargs
if (Array.isArray(prepared.channel_values.messages)) {
// copyCheckpoint only creates a shallow copy, so we need to modify a copy of messages
prepared.channel_values.messages = prepared.channel_values.messages.map((msg) => {
if (!msg?.additional_kwargs) return msg
return { ...msg, additional_kwargs: {} }
})
}
const [, serializedCheckpoint] = await this.serde.dumpsTyped(prepared)
const [, serializedMetadata] = await this.serde.dumpsTyped(metadata)
Expand Down
Loading