Skip to content

fix: deleted internal message data - #213

Merged
Akatuoro merged 5 commits into
mainfrom
fix/shallow-checkpoint-copy
Oct 23, 2026
Merged

Akatuoro merged 5 commits into
mainfrom
fix/shallow-checkpoint-copy

Conversation

@Akatuoro

Copy link
Copy Markdown
Contributor

The OpenAI provider was not working correctly with #184 because we modified the message objects in place instead of having a copy.

No changelog, since this is still the same release.

@Akatuoro
Akatuoro requested review from a team as code owners October 22, 2026 13:35
@hyperspace-pr-bot

Copy link
Copy Markdown

Summary

The following content is AI-generated and provides a summary of the pull request:


Preserve message data when saving checkpoints

Category: Bug Fix

Prevent checkpoint persistence from mutating shared message objects while removing model-internal properties.

  • Create copied message objects before clearing additional_kwargs.
  • Preserve the original in-memory messages required by providers such as OpenAI.
  • Continue excluding model-internal data from persisted checkpoints.
  • Safely handle missing or non-array message collections.

Have you...

  • Added relevant entry to the change log?

Related: #184


  • 🔄 Regenerate and Update Summary
  • ✏️ Insert as PR Description (deletes this comment)
  • 🗑️ Delete comment
PR Bot Information

Version: 1.33.12

BobdenOs
BobdenOs previously approved these changes Oct 22, 2026
@Akatuoro
Akatuoro added this pull request to the merge queue Oct 22, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 22, 2026
@Akatuoro
Akatuoro added this pull request to the merge queue Oct 22, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 22, 2026
@Akatuoro
Akatuoro added this pull request to the merge queue Oct 23, 2026
Merged via the queue into main with commit 7ec9652 Oct 23, 2026
9 checks passed
@Akatuoro
Akatuoro deleted the fix/shallow-checkpoint-copy branch October 23, 2026 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants