Stall Balancing and Multiplicative Upgrade Overhaul - #94
Conversation
- Implement compounding multiplicative damage upgrades (1.15x) for all stalls.
- Update base stats: Chicken Rice (10 dmg, 500ms), Durian (150 dmg), Satay (30 dmg).
- Implement specific fire rate reduction rules and floors:
- Chicken Rice: -15ms reduction, 200ms floor.
- Durian: -50ms reduction, 1000ms floor.
- Satay: -25ms reduction, 750ms floor.
- Remove redundant special-case upgrade logic for Chicken Rice.
- Update STALL_STATS.md documentation with new scaling rules and expanded comparison tables (Levels 24, 36, and 48).
- Ensure UI stat benefit strings in Registry.kt match gameplay logic.
Co-authored-by: candour <4670475+candour@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
📝 WalkthroughWalkthroughUpdated stall balance mechanics and upgrade scaling rules across documentation and code: replaced additive damage increment with multiplicative 1.15x scaling, introduced stall-specific fire-rate reductions with per-stall minimum cooldown floors, adjusted base stats (SATAY +10 damage, CHICKEN_RICE -5 damage/-200ms cooldown, DURIAN +30 damage), and removed dedicated damage-increment method. Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~50 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Build Successful! 🚀Note: This link will be removed when the PR is closed. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
app/src/main/java/com/messark/hawker/MainViewModel.kt (1)
980-1033:⚠️ Potential issue | 🔴 CriticalChicken Rice upgrades can consume gold without applying any stat change
When
upgradeTypeIndex == 2,StallType.CHICKEN_RICEfalls through without settingcurrentCategoryNameor mutating stats, but Line 1078 still deducts gold and commits the upgrade transaction. This creates paid no-op upgrades.💡 Proposed fix (skip unsupported category and try next shuffled category)
when (upgradeTypeIndex) { 0 -> { ... } 1 -> { ... } 2 -> { when (stall.stallType) { StallType.SATAY, StallType.DURIAN -> { ... } StallType.TEH_TARIK -> { ... } StallType.ICE_KACHANG -> { ... } StallType.TRAY_RETURN_UNCLE -> { ... } else -> { // Fallback for any utility stalls or other types that shouldn't hit the above if (stall.stallType.isUtility) { currentCategoryName = "Range" newRange += 0.5f val newLevel = mutableUpgrades.getOrDefault("Range", 0) + 1 if (newLevel % 10 == 0) { newRange *= 1.25f } mutableUpgrades["Range"] = newLevel } } } } } + + if (currentCategoryName.isBlank()) { + // No valid upgrade applied for this category/stall combo; try another category + continue + } var newPrefix = stall.legendaryPrefixAlso applies to: 1078-1078
🧹 Nitpick comments (1)
STALL_STATS.md (1)
68-71: Fix markdownlint MD058 around newly added tablesAdd blank lines around each table block to clear the reported MD058 warnings.
Also applies to: 78-81, 88-91
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: d4e79840-984c-40f4-9a3f-ac77a61ac997
📒 Files selected for processing (3)
STALL_STATS.mdapp/src/main/java/com/messark/hawker/MainViewModel.ktapp/src/main/java/com/messark/hawker/registry/Registry.kt
1 participant
This PR implements a significant balancing overhaul for the game's stalls.
Key changes include:
getUpgradeDamageIncreasemethod and streamlined the upgrade branching inMainViewModel.kt.STALL_STATS.mdto reflect these changes and expanded the average stall comparison tables to include higher-level milestones (Level 36 and Level 48) to better illustrate late-game scaling.All changes have been verified with unit tests and ensure consistency between the game logic and the UI.
PR created automatically by Jules for task 9871894414873740146 started by @candour
Summary by CodeRabbit