Skip to content

Fix missing Chicken Rice upgrade logic - #95

Merged
candour merged 1 commit into
mainfrom
fix-chicken-rice-upgrade-logic-10978814087634744203
Apr 27, 2026
Merged

Fix missing Chicken Rice upgrade logic#95
candour merged 1 commit into
mainfrom
fix-chicken-rice-upgrade-logic-10978814087634744203

Conversation

@candour

@candour candour commented Apr 27, 2026

Copy link
Copy Markdown
Owner

Added missing CHICKEN_RICE case to the special upgrade category (index 2) in MainViewModel.upgradeStall. This ensures that Chicken Rice stalls correctly receive damage upgrades when this category is selected, including the 1.15x multiplicative scaling and 1.25x milestone boost every 10 levels. Verified with unit tests.


PR created automatically by Jules for task 10978814087634744203 started by @candour

Summary by CodeRabbit

  • New Features
    • Added upgrade support for Chicken Rice stalls with damage mechanics
    • Damage increases by 15% per upgrade level, with bonus multiplier applied every 10 levels

The Chicken Rice stall was missing its upgrade logic for the third
upgrade category (Special), which resulted in no stats being improved
when this category was randomly selected. Added the missing Damage
upgrade branch with standard scaling and milestone boosts.

Co-authored-by: candour <4670475+candour@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Apr 27, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 6f53b63e-62aa-4fbd-b343-912f8548c531

📥 Commits

Reviewing files that changed from the base of the PR and between be301a9 and 41bb384.

📒 Files selected for processing (1)
  • app/src/main/java/com/messark/hawker/MainViewModel.kt

📝 Walkthrough

Walkthrough

The change adds StallType.CHICKEN_RICE handling to the stall upgrade logic, routing its upgrades to the "Damage" category with a 1.15x multiplier applied per upgrade level and a 1.25x milestone bonus when the damage level reaches multiples of 10.

Changes

Cohort / File(s) Summary
Chicken Rice Upgrade Logic
app/src/main/java/com/messark/hawker/MainViewModel.kt
Added conditional branch for CHICKEN_RICE stall type in upgrade category index 2, applying 1.15x damage multiplier per upgrade with additional 1.25x multiplier at 10-level milestones.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Fix missing Chicken Rice upgrade logic' directly and clearly summarizes the main change: adding missing upgrade logic for Chicken Rice stalls to the special upgrade category.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-chicken-rice-upgrade-logic-10978814087634744203

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

Copy link
Copy Markdown

Build Successful! 🚀

Download APK

Note: This link will be removed when the PR is closed.

@candour
candour merged commit 4b0c453 into main Apr 27, 2026
3 checks passed
@candour
candour deleted the fix-chicken-rice-upgrade-logic-10978814087634744203 branch April 27, 2026 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant