[sosek108]

Explanation of Change

This builds on the useOnyxState Onyx bump in Expensify#104690 (Onyx Expensify#862).

DERIVED.REPORT_ATTRIBUTES holds the name, the status fields (RBR/GBR, action badge, errors, one-transaction thread ID) and isEmpty of every report. OnyxDerived recomputes it after every relevant write, in a second render wave, and writes the whole map to Onyx and to disk on each flush.

This removes the derived value completely. The per-report compute moves, unchanged, into pure functions (ReportAttributesComputeUtils) and an incremental computer (computeReportAttributes). A module-level cache (ReportAttributesCache) diffs the dependency references and recomputes only the changed reports, so every consumer shares one compute. Readers use new hooks built on useOnyxState: useAllReportAttributes, useReportAttributesEntry, useReportStatus, useReportName, useReportNames and useIsEmptyReport. They read the live store, as the derived value did, not the Search snapshot. When nothing changed, the cache returns the previous object, and unchanged entries keep their reference.

Without persistence, the first compute after boot cost +7.5% on web cold startup for a large account. An idle-saved snapshot (reportAttributesSnapshot, debounced, flushed on background) seeds the first compute when the account and locale match, which brings startup back to parity. A migration clears the old stored reportAttributes value. UnreadIndicatorUpdater no longer subscribes to the key.

Two behaviour fixes come with it: moved and unreported thread names no longer depend on which report was computed first, and entries for deleted reports no longer survive a locale change.

Measurements against Expensify#104690, both legs on the same Onyx build, large account (4,057 reports), web at 4x CPU throttle:

• Send message (visible): 649 -> 544 ms (-16%).
• One report-action write with the Search router open: 683 -> 629 ms (-8%).
• Search router open: 1,164 -> 1,095 ms (-6%).
• Open report and cold startup: parity.
• Reassure at 5,000 reports: locale switch -38%, violation outside the list -29%, comment -11%, visible write -9.5%, render counts identical.
• iOS: startup parity, send visible -13.5% (not significant).

Follow-ups: rename the ReportAttributesDerivedValue type and the reportAttributesDerived* parameters, narrow the libs to a getReportName accessor, and lazy names (Expensify#3260).

Fixed Issues

$ https://github.com/callstack-internal/expensify-issues/issues/3085
PROPOSAL:

Tests

1. Open the LHN. Verify report names, RBR and GBR dots, and the badge count match main.
2. Create an expense with a violation in a workspace chat. Verify the RBR shows on the expense report and propagates to its parent workspace chat.
3. Rename a room. Verify the new name shows in the LHN, the report header and the Search router.
4. Switch the app language. Verify report names (e.g. expense report titles) update in the LHN.
5. Mark a chat as unread and back. Verify the unread indicator and the browser tab badge count update.
6. Open the Search router and type part of a report name. Verify matching reports show with their names.
7. Start a new expense and pick a participant. Verify chats show with their names.
8. Reload the app. Verify the LHN shows the same names and dots right after boot.

• Verify that no errors appear in the JS console

Offline tests

1. Go offline. Add a comment to a chat and rename a room.
2. Verify the LHN updates the chat's preview and the room name.
3. Go back online. Verify the pending state clears and names stay correct.

QA Steps

Same as tests.

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If the PR adds or modifies the UI:
  • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
  • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
  • I verified all new/changed elements have meaningful accessible names and roles.
  • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari