Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
This stacks on #92 (
REPORT_ATTRIBUTESonuseOnyxState), which builds on the Onyx bump in Expensify#104690 (Onyx Expensify#862).DERIVED.VISIBLE_REPORT_ACTIONSholds, for every report, which actions are visible. OnyxDerived recomputes it after every report-action, report or name-value-pairs write and writes the whole map back to Onyx and to disk. A sent message can't render until that value arrives, so the new row waits for the whole OnyxDerived flush.This removes the derived value. Pure selectors compute visibility per report, cached on the report's actions object, so every consumer shares one compute. Per-report readers (LHN rows, the report screen, parent subtitle, context menu, linked-action guard) use
useVisibleReportActions(reportID), which depends only on that report's keys. Search, share and attachment readers useuseAllVisibleReportActions, which keeps a report's previous object when its visibility did not change. Support-ticket survey hiding is unchanged.Measurements against #92, large account (4,057 reports), web at 4x CPU throttle, staging API:
Alone on Expensify#104690, without #92, send is neutral: the row renders earlier, but the remaining OnyxDerived flush still blocks the paint.
Known cost: on send, the chat list re-renders every cell (React self time +41% in a render probe). The follow-up keeps unchanged per-report visibility stable.
Fixed Issues
$ https://github.com/callstack-internal/expensify-issues/issues/3081
PROPOSAL:
Tests
Offline tests
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari