Skip to content

⚡ Bolt: Fix sequential scanning by removing unnecessary actor isolation #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
acebytes wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡ Bolt: Fix sequential scanning by removing unnecessary actor isolation #80

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .jules/bolt.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
## 2026-04-04 - Actor Isolation Blocking Parallelism in TaskGroups
**Learning:** Using an `actor` to manage a `withTaskGroup` where child tasks invoke synchronous, blocking operations directly on the actor (`await self.method()`) inadvertently serializes the tasks on the actor's executor, preventing parallelism.
**Action:** For stateless components interacting with thread-safe dependencies (like `FileManager`), use `struct`s or `nonisolated` methods instead of `actor`s to allow tasks to execute concurrently across threads.
6 changes: 3 additions & 3 deletions Sources/Cacheout/Scanner/CacheScanner.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,13 @@

import Foundation

actor CacheScanner {
struct CacheScanner {
private let fileManager = FileManager.default

func scanAll(_ categories: [CacheCategory]) async -> [ScanResult] {
await withTaskGroup(of: ScanResult.self) { group in
for category in categories {
group.addTask { await self.scanCategory(category) }
group.addTask { self.scanCategory(category) }
}
var results: [ScanResult] = []
for await result in group {
Expand All @@ -42,7 +42,7 @@ actor CacheScanner {
}
}

func scanCategory(_ category: CacheCategory) async -> ScanResult {
func scanCategory(_ category: CacheCategory) -> ScanResult {
let resolvedPaths = category.resolvedPaths
guard !resolvedPaths.isEmpty else {
return ScanResult(category: category, sizeBytes: 0, itemCount: 0, exists: false)
Expand Down
8 changes: 4 additions & 4 deletions Sources/Cacheout/Scanner/NodeModulesScanner.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@

import Foundation

actor NodeModulesScanner {
struct NodeModulesScanner {
private let fileManager = FileManager.default

/// Common directories where developers keep projects
Expand Down Expand Up @@ -62,7 +62,7 @@ actor NodeModulesScanner {
let rootURL = home.appendingPathComponent(root)
guard fileManager.fileExists(atPath: rootURL.path) else { continue }
group.addTask {
await self.findNodeModules(in: rootURL, maxDepth: maxDepth)
self.findNodeModules(in: rootURL, maxDepth: maxDepth)
}
}
for await items in group {
Expand All @@ -77,7 +77,7 @@ actor NodeModulesScanner {
.sorted { $0.sizeBytes > $1.sizeBytes }
}

private func findNodeModules(in directory: URL, maxDepth: Int, currentDepth: Int = 0) async -> [NodeModulesItem] {
private func findNodeModules(in directory: URL, maxDepth: Int, currentDepth: Int = 0) -> [NodeModulesItem] {
guard currentDepth < maxDepth else { return [] }

var results: [NodeModulesItem] = []
Expand Down Expand Up @@ -113,7 +113,7 @@ actor NodeModulesScanner {
let name = item.lastPathComponent
guard !Self.skipDirs.contains(name) else { continue }
guard (try? item.resourceValues(forKeys: [.isDirectoryKey]).isDirectory) == true else { continue }
let subResults = await findNodeModules(in: item, maxDepth: maxDepth, currentDepth: currentDepth + 1)
let subResults = findNodeModules(in: item, maxDepth: maxDepth, currentDepth: currentDepth + 1)
results.append(contentsOf: subResults)
}

Expand Down