⚡ Bolt: Fix sequential scanning by removing unnecessary actor isolation#80
⚡ Bolt: Fix sequential scanning by removing unnecessary actor isolation#80
Conversation
Changed CacheScanner and NodeModulesScanner from `actor` to `struct` to prevent TaskGroup serialization. Previously, Tasks spawned via `withTaskGroup` were inadvertently being serialized due to actor isolation when calling their internal instance methods. Converting them to structs solves this issue and allows scanning to process concurrently, greatly reducing the time necessary to execute cache scanning operations. Co-authored-by: acebytes <2820910+acebytes@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
💡 What: Changed
CacheScannerandNodeModulesScannerfromactortostruct.🎯 Why: Because they used
withTaskGroupand tasks invoked methods onself(await self.scanCategory(...)), Swift's actor isolation was inadvertently forcing all child tasks to run sequentially on the actor's executor. This defeated the purpose ofwithTaskGroupand completely prevented parallel directory scanning. Since these scanners hold no mutable state (they only reference the thread-safeFileManager.default), they do not need actor isolation.📊 Impact: Massively speeds up the scanning process. Directory traversals and cache size calculations will now correctly execute in parallel across cooperative thread pools instead of sequentially blocking on a single executor.
🔬 Measurement: Measure the time elapsed during
CacheoutViewModel.scan(). The time taken to scan multiple large cache directories will drastically drop as parallelization functions as expected.PR created automatically by Jules for task 9175736932781951309 started by @acebytes