Repository navigation
fix: limit bulk actions to rows the user can access - #225
Merged
Merged
Conversation
Bulk actions took row ids straight from the request, so a user could change another account's rows by sending their ids. Resolve the ids through getManyByIds (crudAuth filter) before updating, in attendance bulk edit, approved absences, fix references, student active toggle, report group signature and session time adjustment. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018Ju7CjT3xeJYnaF7vU93GJ
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018Ju7CjT3xeJYnaF7vU93GJ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by הדסה · project thread
Before: bulk actions updated rows by the ids sent from the client, with no ownership check. A user could change another account's rows by sending their ids.
After: every bulk action first resolves the selected ids through
getManyByIds, which applies the crudAuth filter. Ids the caller can't see are dropped, and if none are left the action returns "לא נבחרו רשומות".How: same pattern
attendance-cleanup-rulealready uses. Covered actions:bulkEdit,bulkKnownAbsences,fixStudentReferenceV2,fixReferencesfixReferencesbulkUpdateActiveupdateSignatureDataadjustTimeTests: added cases for an id the caller can't access. Server
tscand the full jest run pass (1151 tests).Generated by Claude Code