Skip to content

feat: bulk edit in grades, approved absences, students, lessons and teachers - #226

Merged
buzz-code merged 3 commits into
mainfrom
claude/shared-bulk-edit
Oct 18, 2026
Merged

buzz-code merged 3 commits into
mainfrom
claude/shared-bulk-edit

Conversation

@buzz-code

Copy link
Copy Markdown
Owner

Requested by הדסה · project thread

Before: "עריכה מרוכזת" existed only in the attendance list, with its own action code. Students had a separate "סימון פעיל/לא פעיל" button.

After: grades, approved absences, students, lessons and teachers also get "עריכה מרוכזת", and attendance works the same as before. Fields left empty don't change. For students, "פעיל" is a nullable choice (empty, yes or no), and it replaces the old active/inactive button.

How:

  • Each server config lists its editable columns in bulkEditFields, and the shared BaseEntityService handles the action (feat: shared bulk edit action driven by bulkEditFields nra-server#73). Attendance overrides it to update the att_report table under the view.
  • Each client entity renders the shared BulkEditButton (feat: add BulkEditButton for the shared bulkEdit action nra-client#63) with its inputs.
  • Fields per table: grades (date, class, teacher, lesson, number of lessons, grade, estimation, comment); approved absences (date, class, lesson, count, code, reason, sender, comment, approved); students (comment, address, active); lessons (teacher, start date, end date, number of lessons, comment); teachers (comment).
  • The admin-only "user" and "year" inputs are removed from the attendance bulk edit, because the server never applied them.
  • Added a roadmap entry.

Merge order: this PR is based on #225 (ownership fix), and its submodule pointers point at the branches of nra-server#73 and nra-client#63. Merge #225, then the two shared PRs. Then point the submodules at their merge commits, and merge this one.

Tests: server tsc plus 1156 jest tests, and client 241 jest tests, all pass. Client vite build passes.


Generated by Claude Code

…eachers

Move to the shared bulk edit (nra-server bulkEditFields + nra-client
BulkEditButton). Attendance keeps its fields and now uses the shared
handler on the att_report table; grades, known absences, students,
lessons and teachers get bulk edit. The student "active/inactive"
button is replaced by bulk edit with a nullable isActive field.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018Ju7CjT3xeJYnaF7vU93GJ
@buzz-code buzz-code self-assigned this Oct 18, 2026
@buzz-code
buzz-code changed the base branch from claude/project-thread-mg93un to main October 18, 2026 18:32
@buzz-code
buzz-code merged commit 317a336 into main Oct 18, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants