Repository navigation
feat: bulk edit in grades, approved absences, students, lessons and teachers - #226
Merged
Merged
Conversation
…eachers Move to the shared bulk edit (nra-server bulkEditFields + nra-client BulkEditButton). Attendance keeps its fields and now uses the shared handler on the att_report table; grades, known absences, students, lessons and teachers get bulk edit. The student "active/inactive" button is replaced by bulk edit with a nullable isActive field. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018Ju7CjT3xeJYnaF7vU93GJ
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018Ju7CjT3xeJYnaF7vU93GJ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by הדסה · project thread
Before: "עריכה מרוכזת" existed only in the attendance list, with its own action code. Students had a separate "סימון פעיל/לא פעיל" button.
After: grades, approved absences, students, lessons and teachers also get "עריכה מרוכזת", and attendance works the same as before. Fields left empty don't change. For students, "פעיל" is a nullable choice (empty, yes or no), and it replaces the old active/inactive button.
How:
bulkEditFields, and the sharedBaseEntityServicehandles the action (feat: shared bulk edit action driven by bulkEditFields nra-server#73). Attendance overrides it to update theatt_reporttable under the view.BulkEditButton(feat: add BulkEditButton for the shared bulkEdit action nra-client#63) with its inputs.Merge order: this PR is based on #225 (ownership fix), and its submodule pointers point at the branches of nra-server#73 and nra-client#63. Merge #225, then the two shared PRs. Then point the submodules at their merge commits, and merge this one.
Tests: server tsc plus 1156 jest tests, and client 241 jest tests, all pass. Client
vite buildpasses.Generated by Claude Code